Skip to content

Adds process_tags to live debugger payloads#3580

Open
dubloom wants to merge 14 commits intomasterfrom
dubloom/process-tags-di
Open

Adds process_tags to live debugger payloads#3580
dubloom wants to merge 14 commits intomasterfrom
dubloom/process-tags-di

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Jan 16, 2026

This PR implements this RFC for dynamic instrumentation.

Add process_tags to dynamic instrumentation payload.

This PR comes with this libdatadog PR: DataDog/libdatadog#1452 which justifies the temporary bump of libdatadog (to show that it works)

@datadog-official
Copy link

datadog-official bot commented Jan 16, 2026

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 1029 Tests failed

telemetry log for failed application of config() from com.datadog.appsec.php.integration.TelemetryTests (Datadog) (Fix with Cursor)
groovy.lang.GroovyRuntimeException: Could not find named-arg compatible constructor. Expecting one of:
com.datadog.appsec.php.TelemetryHelpers$Logs(org.apache.groovy.json.internal.LazyMap)
com.datadog.appsec.php.TelemetryHelpers$Logs()

groovy.lang.GroovyRuntimeException: Could not find named-arg compatible constructor. Expecting one of:
com.datadog.appsec.php.TelemetryHelpers$Logs(org.apache.groovy.json.internal.LazyMap)
com.datadog.appsec.php.TelemetryHelpers$Logs()
	at groovy.lang.MetaClassImpl.retrieveNamedArgCompatibleConstructor(MetaClassImpl.java:1878)
	at groovy.lang.MetaClassImpl.invokeConstructor(MetaClassImpl.java:1898)
	at groovy.lang.MetaClassImpl.invokeConstructor(MetaClassImpl.java:1679)
...

    testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Fix with Cursor)

    testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Fix with Cursor)

View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2df3813 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-02-06 17:18:03

Comparing candidate commit 2df3813 in PR branch dubloom/process-tags-di with baseline commit f1d36ca in branch master.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 189 metrics, 2 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1.557µs; -0.643µs] or [-11.536%; -4.761%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+2.437µs; +4.083µs] or [+2.379%; +3.988%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+5.721µs; +6.639µs] or [+5.527%; +6.414%]

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.21%. Comparing base (f1d36ca) to head (2df3813).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3580   +/-   ##
=======================================
  Coverage   62.21%   62.21%           
=======================================
  Files         141      141           
  Lines       13387    13387           
  Branches     1753     1753           
=======================================
  Hits         8329     8329           
  Misses       4260     4260           
  Partials      798      798           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d36ca...2df3813. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from dubloom/process-tags to master January 19, 2026 12:07
@dubloom dubloom marked this pull request as ready for review January 19, 2026 12:07
@dubloom dubloom requested review from a team as code owners January 19, 2026 12:07
@dubloom dubloom force-pushed the dubloom/process-tags-di branch 2 times, most recently from 923101a to 3ce0af9 Compare January 20, 2026 09:27
Copy link
Contributor

@Leiyks Leiyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌

Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, don't forget to update libdatadog to main before merging.

@dubloom dubloom requested a review from a team as a code owner February 6, 2026 16:14
@dubloom dubloom force-pushed the dubloom/process-tags-di branch from 174f2f4 to 2df3813 Compare February 6, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants