Fix for Vertx flaky test

[vandonr]

What Does This Do

follow up on #11655

• make sure spans are closed on BlockingException
• instrument endHandler on new HttpServerResponseImpl class

Motivation

I think the missing instrumentation on HttpServerResponseImpl is what caused the test to flake with a missing span. Not sure why it's not failing all the time though, maybe a race condition with another callback that finishes the span ?

Additional Notes

This time, the issue was not in the test but in the instrumentation it seems

Contributor Checklist

• Format the title according to the contribution guidelines
• Assign the type: and (comp: or inst:) labels in addition to any other useful labels
• Avoid using close, fix, or any linking keywords when referencing an issue
  Use solves instead, and assign the PR milestone to the issue
• Update the CODEOWNERS file on source file addition, migration, or deletion
• Update public documentation with any new configuration flags or behaviors
• Add your completed PR to the merge queue by commenting /merge. You can also:
  • Customize the commit message associated with the merge with /merge --commit-message "..."
  • Remove your PR from the merge queue with /merge -c
  • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
  • Get more information in this doc

Jira ticket: [PROJ-IDENT]

[dd-octo-sts]

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

• Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebbd5e1486

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Replace the new Spock test with JUnit 5

The repo instructions in /workspace/dd-trace-java/AGENTS.md explicitly say not to write new Groovy/Spock tests and to migrate existing Groovy tests to JUnit 5. This adds a new Spock feature method to the Vert.x 5 test suite, so the new regression coverage should be implemented as JUnit 5 coverage instead of extending the deprecated Groovy suite.

Useful? React with 👍 / 👎.

[datadog-datadog-us1-prod]

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 69.73% (+12.79%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ebbd5e1 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.99 s	13.92 s	[-0.5%; +1.4%] (no difference)
startup:insecure-bank:tracing:Agent	12.98 s	12.94 s	[-0.4%; +1.1%] (no difference)
startup:petclinic:appsec:Agent	16.38 s	16.65 s	[-6.3%; +3.0%] (no difference)
startup:petclinic:iast:Agent	16.89 s	16.89 s	[-0.9%; +0.9%] (no difference)
startup:petclinic:profiling:Agent	16.72 s	16.70 s	[-1.1%; +1.4%] (no difference)
startup:petclinic:sca:Agent	16.86 s	16.77 s	[-0.4%; +1.6%] (no difference)
startup:petclinic:tracing:Agent	16.02 s	16.08 s	[-1.5%; +0.7%] (no difference)

Commit: ebbd5e14 · CI Pipeline · Benchmarking Platform UI

---

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.