Context tests improvement proposals#11839
Conversation
This will help with readability when building complex sequence of events
There was a problem hiding this comment.
More details
This PR refactors test helper infrastructure and adds annotations with zero behavioral impact. The TrackingListener refactoring consolidates event tracking logic and introduces checkpoint-based assertions for cleaner incremental event testing. No production code behavior changes; null annotations are purely for static analysis. All test patterns are correctly ported to the new API.
📊 Validated against 5 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 726b66e · What is Autotest? · Any feedback? Reach out in #autotest
mcculls
left a comment
There was a problem hiding this comment.
Nice test improvements, thanks!
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
ac29db2
into
master
What Does This Do
This PR is a proposal of few refactoring changes:
@NonNullannotation on ContextManager implementation in coreMotivation
Those are proposals. Let me know which one you agree with and want to get merged, and which one should I drop from this branch.
Additional Notes
This is a trimmed down version of #11837
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]