Remove unused SpotBugs suppressions from dd-smoke-tests

[AlexeyKuznetsov-DD]

What Does This Do

Removes now-dead SpotBugs artifacts from dd-smoke-tests:

• Drops all @SuppressFBWarnings annotations and their edu.umd.cs.findbugs.annotations.SuppressFBWarnings imports across the IAST, XSS, APM-tracing-disabled and profiling smoke-test apps.
• Removes the redundant compileOnly 'com.github.spotbugs:spotbugs-annotations' dependency from apm-tracing-disabled/application/build.gradle.

Motivation

SpotBugs is disabled for the entire :dd-smoke-tests subtree in gradle/spotbugs.gradle:

if (project.path.startsWith(":dd-smoke-tests")
  || !(name.endsWith("Main") || name.endsWith("Main_java11"))) {
  it.enabled = false
  return
}

Since the analysis never runs on these fixtures, the @SuppressFBWarnings annotations and the spotbugs-annotations dependency are pure dead weight.

Additional Notes

• com.google.code.findbugs:jsr305 is intentionally kept — it provides @Nonnull/@Nullable used by the Spring Boot fixtures, unrelated to SpotBugs analysis.
• jboss-modules still carries an exclude module: 'spotbugs-annotations' on its custom configurations; left as-is since it's a harmless transitive-exclude, not an analysis config.

🤖 Generated with Claude Code

[dd-octo-sts]

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.97 s	14.04 s	[-1.4%; +0.4%] (no difference)
startup:insecure-bank:tracing:Agent	12.88 s	13.08 s	[-2.4%; -0.6%] (maybe better)
startup:petclinic:appsec:Agent	16.48 s	16.64 s	[-5.5%; +3.6%] (no difference)
startup:petclinic:iast:Agent	16.78 s	16.78 s	[-1.0%; +1.0%] (no difference)
startup:petclinic:profiling:Agent	16.32 s	16.69 s	[-6.7%; +2.2%] (no difference)
startup:petclinic:sca:Agent	16.39 s	16.73 s	[-6.3%; +2.3%] (no difference)
startup:petclinic:tracing:Agent	15.94 s	15.82 s	[-3.6%; +5.1%] (no difference)

Commit: 74d4faf6 · CI Pipeline · Benchmarking Platform UI

---

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

[sarahchen6]

Nice 🧹 !