Redo diagrams with Mermaid#334
Conversation
BenchmarksBenchmark execution time: 2026-07-03 09:11:21 Comparing candidate commit e2c7657 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.
|
147c810 to
0efeece
Compare
|
🎯 Code Coverage (details) 🔗 Commit SHA: e2c7657 | Docs | Datadog PR Page | Give us feedback! |
| space:3 d["Service X - Trace segment 1"]:6 space:2 | ||
| space:4 e["X - segment 1"] f["X - segment 1"]:4 space:2 |
There was a problem hiding this comment.
I'm a little confused by your naming. What do you think of the following suggestion? We could apply this similarly to the other segment as well if you think it makes sense.
| space:3 d["Service X - Trace segment 1"]:6 space:2 | |
| space:4 e["X - segment 1"] f["X - segment 1"]:4 space:2 | |
| space:3 d["Service X - Trace segment 1 - span s"]:6 space:2 | |
| space:4 e["Service X - Trace segment 1 - child span s1"] f["Service X - Trace segment 1 - child span s2"]:4 space:2 |
zacharycmontoya
left a comment
There was a problem hiding this comment.
LGTM with a small non-blocking comment
Description
Replace two diagrams (one in dot and one photo of a drawing) by Mermaid diagrams.
Motivation
Mermaid diagrams are much lighter in the code, and much easier to modify if necessary.
Additional Notes
Jira ticket: IDMPL-549 C++ Tracer: update and improve architecture documentation