Skip to content

Get dd_trace_agent_url from Tracer configuration for meaningful System Tests#325

Merged
xlamorlette-datadog merged 5 commits into
mainfrom
xlamorlette/agent-host-ipv6
Jun 8, 2026
Merged

Get dd_trace_agent_url from Tracer configuration for meaningful System Tests#325
xlamorlette-datadog merged 5 commits into
mainfrom
xlamorlette/agent-host-ipv6

Conversation

@xlamorlette-datadog

@xlamorlette-datadog xlamorlette-datadog commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Motivation

The dd_trace_agent_url, dd_version and dd_trace_enabled values checked by System Tests used to be simply read from the environment variables, so leading to quite dummy tests! Now they are read from the Tracer configuration, to really test if it behaves as expected.

Additional Notes

Jira ticket: IDMPL-380 Really test agent URL parsing.

@pr-commenter

pr-commenter Bot commented Jun 5, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-05 17:35:42

Comparing candidate commit 18c900f in PR branch xlamorlette/agent-host-ipv6 with baseline commit 5a576f7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

@xlamorlette-datadog xlamorlette-datadog changed the title Xlamorlette/agent host ipv6 Get dd_trace_agent_url from Tracer configuration for meaningful System Tests Jun 5, 2026
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 5, 2026

Copy link
Copy Markdown

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 90.86% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 18c900f | Docs | Datadog PR Page | Give us feedback!

@xlamorlette-datadog xlamorlette-datadog marked this pull request as ready for review June 5, 2026 17:27
@xlamorlette-datadog xlamorlette-datadog requested review from a team as code owners June 5, 2026 17:27
@xlamorlette-datadog xlamorlette-datadog requested review from zacharycmontoya and removed request for a team June 5, 2026 17:27
@xlamorlette-datadog xlamorlette-datadog merged commit 93ed055 into main Jun 8, 2026
39 checks passed
@xlamorlette-datadog xlamorlette-datadog deleted the xlamorlette/agent-host-ipv6 branch June 8, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants