Skip to content

Conversation

@jonathanmos
Copy link
Member

@jonathanmos jonathanmos commented Dec 10, 2025

What does this PR do?

Optimize the runtime for generate-sr-assets and add some useful flags.

Flags are:
--help - print out details of supported flags.
--verbose - output useful information to the console during the run.
--path - specify explicitly the path the script should run on.
--followSymlinks - whether the script should follow symlinks while traversing - false by default.
--ignore - ignore certain patterns during the traversal. If no wildcard is provided then it assumes a folder name and ignores as a glob pattern:
e.g. 'legacy' -> '**/legacy/**'

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@jonathanmos jonathanmos marked this pull request as ready for review December 10, 2025 10:53
@jonathanmos jonathanmos requested a review from a team as a code owner December 10, 2025 10:53
cdn34dd
cdn34dd previously approved these changes Dec 10, 2025
Copy link
Contributor

@cdn34dd cdn34dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

@jonathanmos jonathanmos merged commit bea99ab into develop Dec 11, 2025
11 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/new-fix-generate-svg branch December 11, 2025 11:54
@cdn34dd cdn34dd mentioned this pull request Dec 11, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants