Rebuild profiling request for every profiling start#3076
Rebuild profiling request for every profiling start#3076ambushwork merged 1 commit intofeature/perfetto-profilingfrom
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: b9ae78a | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/perfetto-profiling #3076 +/- ##
==============================================================
+ Coverage 71.28% 71.33% +0.05%
==============================================================
Files 893 893
Lines 32689 32694 +5
Branches 5493 5495 +2
==============================================================
+ Hits 23302 23321 +19
+ Misses 7827 7817 -10
+ Partials 1560 1556 -4
🚀 New features to boost your workflow:
|
d0753d4 to
b9ae78a
Compare
|
|
||
| @Test | ||
| fun `M not have the same stop signal W start&stop multiple times`() { | ||
| inOrder(mockService) { |
There was a problem hiding this comment.
I think it is better just to have 2 inOrder(...) { } invocations local to the corresponding // Then sections, rather than wrap the whole test in it.
There was a problem hiding this comment.
It doesn't seem to work, if I break it down into two inOrder block, the second block in not able to know the previous call is verified, and throw error "Wanted 1 time, But was 2 times"
| any<String>(), | ||
| stopSignalCaptor.capture(), | ||
| any(), | ||
| callbackCaptor.capture() |
There was a problem hiding this comment.
| callbackCaptor.capture() | |
| any() |
captured value is not read anyway
What does this PR do?
Prior to this PR, in
PerfettoProfilethe cancel signal and profiling request are created only when the class is initialized (not recreated if thestartis called for another time), which causes the following request can't be cancelled, because the original cancel signal is already cancelled before thus in a "cancelled" state.Motivation
This changes will be necessary to support multiple profiling request in the future.
Review checklist (to be filled by reviewers)