FFL-1460 FlagsClient changes to accommodate Flags RN SDK sync flag evals by yugisu-flux · Pull Request #3049 · DataDog/dd-sdk-android

yugisu-flux · 2025-12-11T10:53:07Z

What does this PR do?

This PR introduces new exposed "internal" APIs supporting the upcoming Flags SDK for React Native.

Changes:

New "internal" method for retrieving a snapshot of all precomputed flags to FlagsClient
New "internal" method for tracking a flag evaluation within a certain EvaluationContext
Add a _FlagsInternalProxy class for FlagsClient
Add an UnparsedFlag interface to prevent PrecomputedFlag from being exposed to the public

"internal" APIs = exposed APIs that are added purely for consumption within the RN SDK. This implementation follows the example of _RumInternalProxy.

Motivation

The motivation for this work is to allow the upcoming Flags RN SDK to retrieve the complete feature flags state snapshot from the JS side at SDK init time (FFL-1460).

Additional Notes

I've been developing these changes using the example application in the dd-sdk-reactnative repo (by leveraging composite builds)

Sibling PRs in the React Native and iOS repos:

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Make sure you discussed the feature or bugfix with the maintaining team in an Issue
Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

…nd tracking evaluations

…ta class

0xnm

I added some suggestions, nothing blocking, mostly about API/logging. I think it is a final round and we are good to go after.

0xnm · 2025-12-16T13:53:01Z

+                val errorMessage = "Failed to parse value '${flag.variationValue}' as JSONObject - ${exception.message}"
+                featureSdkCore.internalLogger.log(
+                    InternalLogger.Level.WARN,
+                    InternalLogger.Target.MAINTAINER,


Should the target be the USER? Since I guess it is about user data parsing

This log is corresponding to the flags data parsing logic in readAndParseAssignment (line 289).

My point here is that MAINTAINER target logs are visible only in the SDK debug builds, they won't be shown in the release build. So if user needs to know about this error, it should be USER target.

@typotter FYI the target has been changed to USER in other related flag value parsing logic as well. Does that work for you?

datadog-official · 2025-12-16T14:04:08Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Overall Coverage: 66.45% (-0.11%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 0046c64 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

codecov-commenter · 2025-12-16T14:08:12Z

Codecov Report

❌ Patch coverage is 73.46939% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.55%. Comparing base (70ecc68) to head (0046c64).
⚠️ Report is 822 commits behind head on develop.

Files with missing lines	Patch %	Lines
...n/com/datadog/android/flags/_FlagsInternalProxy.kt	0.00%	7 Missing ⚠️
...lags/internal/repository/DefaultFlagsRepository.kt	33.33%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3049      +/-   ##
===========================================
+ Coverage    71.46%   71.55%   +0.09%     
===========================================
  Files          880      881       +1     
  Lines        32480    32544      +64     
  Branches      5473     5481       +8     
===========================================
+ Hits         23211    23286      +75     
- Misses        7728     7739      +11     
+ Partials      1541     1519      -22

Files with missing lines	Coverage Δ
...tadog/android/flags/internal/DatadogFlagsClient.kt	`92.50% <100.00%> (+1.20%)`	⬆️
.../android/flags/internal/ExposureEventsProcessor.kt	`100.00% <ø> (ø)`
...og/android/flags/internal/model/PrecomputedFlag.kt	`100.00% <100.00%> (ø)`
...lags/internal/repository/DefaultFlagsRepository.kt	`60.00% <33.33%> (-4.71%)`	⬇️
...n/com/datadog/android/flags/_FlagsInternalProxy.kt	`0.00% <0.00%> (ø)`

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

typotter

lgtm, approved.
Just a suggestion but nothing blocking from ffe. 🚢

typotter · 2026-01-05T16:34:29Z

-                flag.variationValue
-            }
-            else -> null
+        val variationTypeToKClass = mapOf(


nit: this could be a static constant instead of being redefined everytime the function runs.

yugisu-flux · 2026-01-06T15:49:08Z

/merge

dd-devflow-routing-codex · 2026-01-06T15:49:14Z

View all feedbacks in Devflow UI.

2026-01-06 15:49:13 UTC ℹ️ Start processing command /merge

2026-01-06 15:49:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in develop is approximately 57m (p90).

2026-01-06 16:54:23 UTC ℹ️ MergeQueue: This merge request was merged

FFL-1460 Add internal methods for retrieving a flags state snapshot a…

61e3693

…nd tracking evaluations

yugisu-flux requested a review from typotter December 11, 2025 10:53

yugisu-flux self-assigned this Dec 11, 2025

yugisu-flux requested a review from a team as a code owner December 11, 2025 10:53

yugisu-flux mentioned this pull request Dec 11, 2025

FFL-1460 FlagsClient changes to accommodate Flags RN SDK sync flag evals DataDog/dd-sdk-ios#2604

Merged

4 tasks

yugisu-flux added 3 commits December 11, 2025 13:39

FFL-1460 Run ktlint

0f81db5

Move PrecomputedFlag to public, mark as InternalApi

41290fa

Update apiSurface, fix ktlint errors

ca508fe

yugisu-flux force-pushed the dima/FFL-1460-sync-flag-evaluation-in-rn-sdk branch from f3efb76 to ca508fe Compare December 11, 2025 18:01

Fis build issues

187cbd9

0xnm requested changes Dec 12, 2025

View reviewed changes

typotter reviewed Dec 12, 2025

View reviewed changes

yugisu-flux added 3 commits December 15, 2025 19:33

FFL-1460 Move PrecomputedFlagConstants back, run proper ktlint

75c21dd

FFL-1460 Remove FlagsClient._getInternal method

797b4ef

Rework the exposed internal APIs to not expose the PrecomputedFlag da…

092a703

…ta class

yugisu-flux requested review from 0xnm and typotter December 15, 2025 18:48

0xnm requested changes Dec 16, 2025

View reviewed changes

yugisu-flux added 6 commits December 16, 2025 14:53

FFL-1460 Improve error logging in the parseFlagValueString method

211d32a

FFL-1460 Remove unnecessary lint suppressions

ebd67fa

FFL-1460 Make PrecomputedFlag internal again

05570ee

FFL-1460 Address linter errors

a315d75

FFL-1460 Add tests for new exposed internal APIs

dfe9808

FFL-1460 Add tests for DefaultFlagsRepository.getFlagsSnapshot

cff21c8

yugisu-flux requested a review from 0xnm December 16, 2025 13:34

yugisu-flux commented Dec 16, 2025

View reviewed changes

Comment thread features/dd-sdk-android-flags/src/main/kotlin/com/datadog/android/flags/model/UnparsedFlag.kt

0xnm reviewed Dec 16, 2025

View reviewed changes

yugisu-flux mentioned this pull request Dec 16, 2025

FFL-1460 Update Flags SDK to evaluate feature flags synchronously DataDog/dd-sdk-reactnative#1064

Merged

4 tasks

yugisu-flux requested review from 0xnm and typotter January 5, 2026 14:36

FFL-1460 ktlint fix

0fa6c2f

0xnm previously approved these changes Jan 5, 2026

View reviewed changes

typotter previously approved these changes Jan 5, 2026

View reviewed changes

FFL-1460 Fix tests

ed7f053

yugisu-flux dismissed stale reviews from typotter and 0xnm via ed7f053 January 5, 2026 16:48

typotter previously approved these changes Jan 5, 2026

View reviewed changes

0xnm previously approved these changes Jan 5, 2026

View reviewed changes

ktlint fixes

834914f

yugisu-flux dismissed stale reviews from 0xnm and typotter via 834914f January 6, 2026 11:19

Merge branch 'develop' into dima/FFL-1460-sync-flag-evaluation-in-rn-sdk

6a468ba

0xnm previously approved these changes Jan 6, 2026

View reviewed changes

yugisu-flux added 2 commits January 6, 2026 14:29

FFL-1460 Fix trackFlagSnapshotEvaluation tests

4ac5b7a

FFL-1460 Bring variationTypeToKClass to a companion object

0046c64

yugisu-flux dismissed 0xnm’s stale review via 0046c64 January 6, 2026 12:37

yugisu-flux requested a review from 0xnm January 6, 2026 13:35

0xnm approved these changes Jan 6, 2026

View reviewed changes

dd-devflow Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels Jan 6, 2026

dd-mergequeue Bot merged commit d370277 into develop Jan 6, 2026
27 of 30 checks passed

dd-mergequeue Bot deleted the dima/FFL-1460-sync-flag-evaluation-in-rn-sdk branch January 6, 2026 16:54

dd-devflow Bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Jan 6, 2026

0xnm restored the dima/FFL-1460-sync-flag-evaluation-in-rn-sdk branch March 26, 2026 10:49

Conversation

yugisu-flux commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xnm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0xnm Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

yugisu-flux Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

0xnm Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

yugisu-flux Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

datadog-official Bot commented Dec 16, 2025 • edited by datadog-datadog-prod-us1 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

typotter left a comment

Choose a reason for hiding this comment

Uh oh!

typotter Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

yugisu-flux commented Jan 6, 2026

Uh oh!

dd-devflow-routing-codex Bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yugisu-flux commented Dec 11, 2025 •

edited

Loading

datadog-official Bot commented Dec 16, 2025 •

edited by datadog-datadog-prod-us1 Bot

Loading

codecov-commenter commented Dec 16, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Jan 6, 2026 •

edited

Loading