Skip to content

WIP: No logs in yarn test#1699

Draft
Drarig29 wants to merge 12 commits intomasterfrom
corentin.girard/better-tests
Draft

WIP: No logs in yarn test#1699
Drarig29 wants to merge 12 commits intomasterfrom
corentin.girard/better-tests

Conversation

@Drarig29
Copy link
Copy Markdown
Contributor

@Drarig29 Drarig29 commented Jun 17, 2025

What and why?

TODO: disallow console with ESLint, and remove all usages of it in favor of passing the command context

How?

A brief description of implementation details of this PR.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Jun 17, 2025

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Other Violations

🧪 6 Tests failed

execute should not output anything if silent mode is enabled from src/commands/tag/__tests__/tag.test.ts   View in Datadog   (Fix with Cursor)
Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout.
execute should not output anything if silent mode is enabled from src/commands/tag/__tests__/tag.test.ts   View in Datadog   (Fix with Cursor)
Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout.
execute should not output anything if silent mode is enabled from src/commands/tag/__tests__/tag.test.ts   View in Datadog   (Fix with Cursor)
Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout.
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e801925 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@Drarig29 Drarig29 added the chores Related to the CI or developer experience label Jun 17, 2025
@Drarig29 Drarig29 force-pushed the corentin.girard/better-tests branch from a451efa to b5aa717 Compare June 17, 2025 19:12
@Drarig29 Drarig29 changed the base branch from master to corentin.girard/upgrade-form-data June 17, 2025 19:13
@Drarig29 Drarig29 force-pushed the corentin.girard/better-tests branch 2 times, most recently from ee7727c to e801925 Compare June 18, 2025 12:14
Base automatically changed from corentin.girard/upgrade-form-data to master June 20, 2025 10:17
@Drarig29 Drarig29 closed this Apr 10, 2026
@Drarig29 Drarig29 changed the title Always use command context for stdout and stderr WIP: No logs in yarn test Apr 10, 2026
@Drarig29 Drarig29 deleted the corentin.girard/better-tests branch April 10, 2026 20:34
@Drarig29 Drarig29 restored the corentin.girard/better-tests branch April 10, 2026 20:34
@Drarig29 Drarig29 reopened this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chores Related to the CI or developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant