Skip to content

Support decimal sample_rate for RUM retention filters #3310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
api-clients-generation-pipeline wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support decimal sample_rate for RUM retention filters #3310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45104,12 +45104,12 @@ components:
$ref: '#/components/schemas/RumRetentionFilterData'
type: object
RumRetentionFilterSampleRate:
description: The sample rate for a RUM retention filter, between 0 and 100.
example: 25
format: int64
description: The sample rate for a RUM retention filter, between 0.1 and 100.
example: 50.5
format: double
maximum: 100
minimum: 0
type: integer
minimum: 0.1
type: number
RumRetentionFilterType:
default: retention_filters
description: The type of the resource. The value should always be retention_filters.
Expand Down
2 changes: 1 addition & 1 deletion examples/v2/rum-retention-filters/CreateRetentionFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static void main(String[] args) {
.name("Test creating retention filter")
.eventType(RumRetentionFilterEventType.SESSION)
.query("custom_query")
.sampleRate(50L)
.sampleRate(50.0)
.enabled(true)));

try {
Expand Down
2 changes: 1 addition & 1 deletion examples/v2/rum-retention-filters/UpdateRetentionFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public static void main(String[] args) {
.name("Test updating retention filter")
.eventType(RumRetentionFilterEventType.VIEW)
.query("view_query")
.sampleRate(100L)
.sampleRate(100.0)
.enabled(true)));

try {
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/com/datadog/api/client/v2/model/RumRetentionFilterAttributes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class RumRetentionFilterAttributes {
private String query;

public static final String JSON_PROPERTY_SAMPLE_RATE = "sample_rate";
private Long sampleRate;
private Double sampleRate;

public RumRetentionFilterAttributes enabled(Boolean enabled) {
this.enabled = enabled;
Expand Down Expand Up @@ -131,24 +131,24 @@ public void setQuery(String query) {
this.query = query;
}

public RumRetentionFilterAttributes sampleRate(Long sampleRate) {
public RumRetentionFilterAttributes sampleRate(Double sampleRate) {
this.sampleRate = sampleRate;
return this;
}

/**
* The sample rate for a RUM retention filter, between 0 and 100. minimum: 0 maximum: 100
* The sample rate for a RUM retention filter, between 0.1 and 100. minimum: 0.1 maximum: 100
*
* @return sampleRate
*/
@jakarta.annotation.Nullable
@JsonProperty(JSON_PROPERTY_SAMPLE_RATE)
@JsonInclude(value = JsonInclude.Include.USE_DEFAULTS)
public Long getSampleRate() {
public Double getSampleRate() {
return sampleRate;
}

public void setSampleRate(Long sampleRate) {
public void setSampleRate(Double sampleRate) {
this.sampleRate = sampleRate;
}

Expand Down
12 changes: 6 additions & 6 deletions src/main/java/com/datadog/api/client/v2/model/RumRetentionFilterCreateAttributes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class RumRetentionFilterCreateAttributes {
private String query;

public static final String JSON_PROPERTY_SAMPLE_RATE = "sample_rate";
private Long sampleRate;
private Double sampleRate;

public RumRetentionFilterCreateAttributes() {}

Expand All @@ -51,7 +51,7 @@ public RumRetentionFilterCreateAttributes(
@JsonProperty(required = true, value = JSON_PROPERTY_EVENT_TYPE)
RumRetentionFilterEventType eventType,
@JsonProperty(required = true, value = JSON_PROPERTY_NAME) String name,
@JsonProperty(required = true, value = JSON_PROPERTY_SAMPLE_RATE) Long sampleRate) {
@JsonProperty(required = true, value = JSON_PROPERTY_SAMPLE_RATE) Double sampleRate) {
this.eventType = eventType;
this.unparsed |= !eventType.isValid();
this.name = name;
Expand Down Expand Up @@ -144,23 +144,23 @@ public void setQuery(String query) {
this.query = query;
}

public RumRetentionFilterCreateAttributes sampleRate(Long sampleRate) {
public RumRetentionFilterCreateAttributes sampleRate(Double sampleRate) {
this.sampleRate = sampleRate;
return this;
}

/**
* The sample rate for a RUM retention filter, between 0 and 100. minimum: 0 maximum: 100
* The sample rate for a RUM retention filter, between 0.1 and 100. minimum: 0.1 maximum: 100
*
* @return sampleRate
*/
@JsonProperty(JSON_PROPERTY_SAMPLE_RATE)
@JsonInclude(value = JsonInclude.Include.ALWAYS)
public Long getSampleRate() {
public Double getSampleRate() {
return sampleRate;
}

public void setSampleRate(Long sampleRate) {
public void setSampleRate(Double sampleRate) {
this.sampleRate = sampleRate;
}

Expand Down
10 changes: 5 additions & 5 deletions src/main/java/com/datadog/api/client/v2/model/RumRetentionFilterUpdateAttributes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class RumRetentionFilterUpdateAttributes {
private String query;

public static final String JSON_PROPERTY_SAMPLE_RATE = "sample_rate";
private Long sampleRate;
private Double sampleRate;

public RumRetentionFilterUpdateAttributes enabled(Boolean enabled) {
this.enabled = enabled;
Expand Down Expand Up @@ -131,24 +131,24 @@ public void setQuery(String query) {
this.query = query;
}

public RumRetentionFilterUpdateAttributes sampleRate(Long sampleRate) {
public RumRetentionFilterUpdateAttributes sampleRate(Double sampleRate) {
this.sampleRate = sampleRate;
return this;
}

/**
* The sample rate for a RUM retention filter, between 0 and 100. minimum: 0 maximum: 100
* The sample rate for a RUM retention filter, between 0.1 and 100. minimum: 0.1 maximum: 100
*
* @return sampleRate
*/
@jakarta.annotation.Nullable
@JsonProperty(JSON_PROPERTY_SAMPLE_RATE)
@JsonInclude(value = JsonInclude.Include.USE_DEFAULTS)
public Long getSampleRate() {
public Double getSampleRate() {
return sampleRate;
}

public void setSampleRate(Long sampleRate) {
public void setSampleRate(Double sampleRate) {
this.sampleRate = sampleRate;
}

Expand Down
Loading