Skip to content

Comments

[AWSCORE-511] Add cloud formation template for CUR 2.0#261

Merged
dhan0779 merged 6 commits intomasterfrom
david.han/awscore-511-cur2-cloud-formation
Jan 8, 2026
Merged

[AWSCORE-511] Add cloud formation template for CUR 2.0#261
dhan0779 merged 6 commits intomasterfrom
david.han/awscore-511-cur2-cloud-formation

Conversation

@dhan0779
Copy link
Contributor

@dhan0779 dhan0779 commented Nov 21, 2025

Note: Please remember to review the contribution guidelines
if you have not yet done so.

What does this PR do?

This PR adds a new cloud formation template for using CUR 2.0 for AWS accounts. The template creates an S3 bucket (if not existing) and sets up the data exports which transfers billing files to the bucket. Additionally, it calls the Datadog API to update the AWS account with CCM configs provided from the parameters.

Testing Guidelines

I tested the release script by uploading it to a private bucket (on the playground sandbox account). For testing functionality, I created a stack with the template using the AWS CLI. I was able to confirm that it properly sets up the S3 bucket and the Data Export with the given bucket. I was also able to confirm that the data_export_configs for the account was properly set through this workflow.

Additional Notes

Anything else we should know when reviewing?

@dhan0779 dhan0779 requested a review from a team as a code owner November 21, 2025 20:09
Copy link
Member

@RaphaelAllier RaphaelAllier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind also updating this doc https://datadoghq.atlassian.net/wiki/spaces/AWS/pages/3085599235/Deploy+Cloudformation+Templates once the PR is merged ?

Made a new nit comments, I think someone from core with some CFN knowledge should review the template

@@ -0,0 +1,3 @@
## 0.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nit: Since the repo is for cloudformation mentioning aws in the path doesn't bring much

LoggingConfig:
ApplicationLogLevel: "INFO"
LogFormat: "JSON"
Runtime: "python3.11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 suggestion: ‏Let's start not in the past and pick a runtime that doesn't make it obsolete like Python 3.14, see https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html

@@ -0,0 +1,3 @@
## 0.0.1
Copy link
Contributor

@klivan klivan Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this matters: you're using aws_cloud_cost_cur2 in the bucket everywhere, but the folder where this is located is called cloud_cost_cur2. Also, all other folder in this repo start with aws_.
Should we make it aws_cloud_cost_cur2 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I'll change it to aws_cloud_cost_cur2 for consistency in the repo.

@dhan0779 dhan0779 merged commit 53abe6e into master Jan 8, 2026
5 checks passed
@dhan0779 dhan0779 deleted the david.han/awscore-511-cur2-cloud-formation branch January 8, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants