Skip to content

fix: localize aria labels#150

Merged
DataDave-Dev merged 1 commit into
DataDave-Dev:mainfrom
lovewave02:codex/55-localize-aria-labels
Jul 7, 2026
Merged

fix: localize aria labels#150
DataDave-Dev merged 1 commit into
DataDave-Dev:mainfrom
lovewave02:codex/55-localize-aria-labels

Conversation

@lovewave02

@lovewave02 lovewave02 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Qué hace

Fixes #55.

Localizes the remaining assistive-technology labels that were hardcoded in English:

  • primary sections navigation
  • language selector
  • mobile menu
  • docs sidebar landmark
  • resize-panel separator
  • footer GitHub link

The visible UI copy stays unchanged; this only moves the aria-label values into the locale dictionaries so screen-reader users get localized landmark/control names.

Tipo

  • feat
  • fix
  • refactor
  • docs
  • test
  • chore

Checklist

  • pnpm lint pasa
  • pnpm typecheck pasa
  • pnpm test pasa
  • pnpm build pasa
  • Si agrega un lenguaje, incluye su test

Verification

  • npx --yes prettier@3.8.4 --check src/components/layout/Header.tsx src/components/docs/DocsSidebar.tsx src/components/layout/Footer.tsx src/components/ui/CodeWorkspace.tsx 'src/app/[lang]/app/page.tsx' src/i18n/dictionaries/en.json src/i18n/dictionaries/es.json src/i18n/dictionaries/pt.json src/i18n/dictionaries/fr.json src/i18n/dictionaries/it.json src/i18n/dictionaries/ar.json
  • npx --yes pnpm@11.0.0 lint
  • npx --yes pnpm@11.0.0 typecheck
  • npx --yes pnpm@11.0.0 test src/i18n/i18n.test.ts
  • npx --yes pnpm@11.0.0 build

Note: the local machine is on Node v22.23.1, so pnpm prints the repo's expected Node 24.x engine warning before the checks. The checks above still passed.

Summary by CodeRabbit

  • New Features
    • Added localized accessibility labels across the app for navigation, language selection, menu controls, documentation links, panel resizing, and the GitHub link.
    • Expanded the workspace splitter label to support localization.
  • Bug Fixes
    • Replaced remaining hardcoded accessibility text with language-specific values, improving consistency for multilingual users.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@lovewave02, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e9d94082-2e03-4b4d-8361-67cdc36c1e97

📥 Commits

Reviewing files that changed from the base of the PR and between e7c8c4b and b40310d.

📒 Files selected for processing (11)
  • src/app/[lang]/app/page.tsx
  • src/components/docs/DocsSidebar.tsx
  • src/components/layout/Footer.tsx
  • src/components/layout/Header.tsx
  • src/components/ui/CodeWorkspace.tsx
  • src/i18n/dictionaries/ar.json
  • src/i18n/dictionaries/en.json
  • src/i18n/dictionaries/es.json
  • src/i18n/dictionaries/fr.json
  • src/i18n/dictionaries/it.json
  • src/i18n/dictionaries/pt.json
📝 Walkthrough

Walkthrough

Hardcoded English aria-label strings in Header, Footer, DocsSidebar, and CodeWorkspace are replaced with values sourced from a new aria object added to all i18n dictionary files (ar, en, es, fr, it, pt), and AppPage passes a new resizePanelsLabel prop into CodeWorkspace.

Changes

Localized accessibility labels

Layer / File(s) Summary
Add aria dictionary keys
src/i18n/dictionaries/*.json
New top-level aria objects with sections, selectLanguage, menu, docs, resizePanels, and githubRepository keys added to all locale dictionaries.
Header and Footer aria-label wiring
src/components/layout/Header.tsx, src/components/layout/Footer.tsx
Nav, language dropdown, mobile menu, and GitHub link aria-labels now use dictionary values instead of hardcoded strings.
DocsSidebar aria-label wiring
src/components/docs/DocsSidebar.tsx
Sidebar <nav> aria-label sourced from t.aria.docs.
CodeWorkspace resizePanelsLabel prop and page wiring
src/components/ui/CodeWorkspace.tsx, src/app/[lang]/app/page.tsx
Props extended with resizePanelsLabel, used for splitter aria-label; AppPage passes localized label; includes unrelated reformatting of LANGUAGES array and an editor wrapper div.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem
A rabbit hopped through every locale,
swapping stiff English for words more tonal,
"Sections," "Docs," and "Resize" too,
now speak the tongue that fits for you.
Ears twitch with pride at labels clear—
accessible burrows, far and near. 🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The diff also includes unrelated formatting-only changes in CodeWorkspace, such as reformatting LANGUAGES and div attributes. Move formatting-only edits to a separate PR or revert them so this change stays limited to aria-label localization.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: localizing aria labels.
Description check ✅ Passed The description matches the repository template with Qué hace, Tipo, and Checklist sections filled in.
Linked Issues check ✅ Passed The code changes localize the exact aria-labels listed in #55 across Header, DocsSidebar, CodeWorkspace, Footer, and dictionaries.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lovewave02 lovewave02 force-pushed the codex/55-localize-aria-labels branch from e7c8c4b to b40310d Compare July 6, 2026 14:21
@DataDave-Dev DataDave-Dev merged commit 0a1d18e into DataDave-Dev:main Jul 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Localize hardcoded English aria-labels

2 participants