Add least-privilege permissions to GitHub Actions workflows#1
Merged
Conversation
CodeQL flagged ci.yml and publish.yml for running with the default GITHUB_TOKEN permissions (rule: "Workflow does not contain permissions", 3 Medium alerts). Added an explicit top-level `permissions: contents: read` to both workflows. Jobs that genuinely need more -- OIDC publishing to PyPI (id-token: write) and creating a GitHub Release (contents: write) -- already declare those in their own per-job permissions blocks, which override the least-privilege default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the 3 CodeQL "Workflow does not contain permissions" alerts (Medium) on
main.ci.ymlandpublish.ymlran with the defaultGITHUB_TOKENpermissions. This adds an explicit top-levelpermissions: contents: readto both — least privilege. Jobs that need more (OIDC publishing to PyPI viaid-token: write, GitHub Release creation viacontents: write) already declare it in their own per-jobpermissionsblocks, which override the default.Effect
Test plan