Skip to content

fix: avoid marimo UI value access in math_eq_editor#31

Merged
Mjboothaus merged 1 commit into
mainfrom
fix/math-eq-editor-marimo-ui-value
Apr 18, 2026
Merged

fix: avoid marimo UI value access in math_eq_editor#31
Mjboothaus merged 1 commit into
mainfrom
fix/math-eq-editor-marimo-ui-value

Conversation

@Mjboothaus
Copy link
Copy Markdown
Contributor

Summary

  • fix math_eq_editor(...) to avoid reading save_button.value in the cell that creates the UI element
  • keep inline edit + save + preview behaviour while complying with marimo UI lifecycle rules
  • add regression test coverage that fails if the helper tries to access button value in creator cell

Validation

  • uv run ruff format src/pdealchemy/notebook_utils.py tests/notebook/test_notebook_utils.py
  • uv run ruff check src/pdealchemy/notebook_utils.py tests/notebook/test_notebook_utils.py
  • uv run ty check src
  • uv run pytest tests/notebook/test_notebook_utils.py tests/notebook/test_notebook_spec.py tests/cli/test_notebook_to_toml.py
  • uv run --extra interactive marimo check examples/notebooks/spec_black_scholes_with_results.py

Context

Co-Authored-By: Oz oz-agent@warp.dev

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 18, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  src/pdealchemy/notebook_utils.py  0% smaller
  tests/notebook/test_notebook_utils.py  0% smaller

@Mjboothaus Mjboothaus merged commit c4819f6 into main Apr 18, 2026
0 of 3 checks passed
@Mjboothaus Mjboothaus deleted the fix/math-eq-editor-marimo-ui-value branch April 18, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant