Skip to content

Deduplicate TOML rendering and spec test fixtures#22

Merged
Mjboothaus merged 1 commit into
mainfrom
refactor/toml-utils-and-test-fixtures
Apr 18, 2026
Merged

Deduplicate TOML rendering and spec test fixtures#22
Mjboothaus merged 1 commit into
mainfrom
refactor/toml-utils-and-test-fixtures

Conversation

@Mjboothaus
Copy link
Copy Markdown
Contributor

Summary

  • extract shared TOML string rendering into src/pdealchemy/toml_rendering.py
  • reuse the shared renderer in notebook_spec and spec_bridge
  • add shared write_spec_toml pytest fixture in tests/conftest.py and remove duplicated test helper implementations

Validation

  • uv run ruff check src/pdealchemy/notebook_spec.py src/pdealchemy/spec_bridge.py src/pdealchemy/toml_rendering.py tests/conftest.py tests/notebook/test_spec_bridge.py tests/cli/test_spec_to_runtime_toml.py
  • uv run ty check src
  • uv run pytest tests/notebook/test_notebook_spec.py tests/cli/test_notebook_to_toml.py tests/notebook/test_spec_bridge.py tests/cli/test_spec_to_runtime_toml.py

Conversation: https://app.warp.dev/conversation/79aa7721-1947-44e5-840f-d20883bd8624
Plan: https://app.warp.dev/drive/notebook/eZQFltrUPlV50R8ZwHEybR

Co-Authored-By: Oz oz-agent@warp.dev

Co-Authored-By: Oz <oz-agent@warp.dev>
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 18, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  tests/notebook/test_spec_bridge.py  24% smaller
  tests/cli/test_spec_to_runtime_toml.py  16% smaller
  src/pdealchemy/notebook_spec.py  0% smaller
  src/pdealchemy/spec_bridge.py  0% smaller
  src/pdealchemy/toml_rendering.py  0% smaller
  tests/conftest.py  0% smaller

@Mjboothaus Mjboothaus merged commit b5f5726 into main Apr 18, 2026
0 of 3 checks passed
@Mjboothaus Mjboothaus deleted the refactor/toml-utils-and-test-fixtures branch April 18, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant