Skip to content

Inspect missing cache files and fix lock races#5537

Open
adamnovak wants to merge 5 commits into
masterfrom
issues/5084-sniff-cache
Open

Inspect missing cache files and fix lock races#5537
adamnovak wants to merge 5 commits into
masterfrom
issues/5084-sniff-cache

Conversation

@adamnovak

Copy link
Copy Markdown
Member

This adds code for dumping information about the cache database state if #5084 happens.

I tried to trigger it somehow by running the caching filestore tests locally, and I found a different bug, which is a race in a bunch of places we use safe_lock(), because safe_lock() makes no guarantees that the file you locked is still the one at the path you opened. We already handled this in the mutex implementation, but we didn't handle this in other places where the file might be going away or being replaced.

So this fixes that problem. I still haven't been able to actually trigger #5084 on my machine though.

Changelog Entry

To be copied to the draft changelog by merger:

  • PR submitter writes their recommendation for a changelog entry here

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
  • Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant