Improve configuration validation around autoscaling#5525
Merged
Conversation
…'t supposed to be used
… and autoscaler from actually starting
…er combinations early and with a sensible message.
…tput for inconsistent configurations
…tem that will be present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix #5380 by preventing the workflow from starting up at all when given a provisioner and a batch system that shouldn't be used together.
It also revises some of the logging and error reporting to make the resulting message more human-readable.
I have several levels of errors now, some of which one shouldn't be able to reach unless one somehow sneaks past the previous levels. But I suppose it's possible someone is doing weird things in a Python workflow?
Changelog Entry
To be copied to the draft changelog by merger:
toil launch-clusterwill no longer try and launch a cluster without a--keyPairName.Reviewer Checklist
issues/XXXX-fix-the-thingin the Toil repo, or from an external repo.camelCasethat want to be insnake_case.docs/running/{cliOptions,cwl,wdl}.rstMerger Checklist