Skip to content

Fix flaky anvil-catalog filter deselection test #4771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NoopDog merged 2 commits into from
Apr 15, 2026
Merged

Fix flaky anvil-catalog filter deselection test #4771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da4cbb3
Initial plan
Copilot Apr 15, 2026
82b6b0c
fix(e2e): use name-based locator in selectFirstOption to avoid flakiness
Copilot Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion e2e/anvil-catalog/anvilcatalog-filters.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,19 @@ async function openFilterDropdown(
await expectFilterPopoverOpen(filters.page());
}

/**
* Returns a locator for a named filter item in the open filter popover.
* @param page - Page.
* @param optionName - The display name of the filter option.
* @returns A locator for the matching filter item.
*/
function namedPopoverFilterItem(page: Page, optionName: string): Locator {
return filterPopover(page)
.getByTestId(TEST_IDS.FILTER_ITEM)
.filter({ hasText: new RegExp(`^${escapeRegExp(optionName)}\\s*\\d+\\s*`) })
.first();
}

/**
* Opens a sidebar filter dropdown, selects its first option, and returns the
* option name. Waits for the item to be selected before returning.
Expand All @@ -260,7 +273,10 @@ async function selectFirstOption(
const name = await extractOptionName(option);
await expectFilterItemNotSelected(option);
await option.click();
await expectFilterItemSelected(option);
// Re-locate by name rather than position since the list may re-sort after
// selection, causing the positional `.first()` locator to resolve to a
// different (non-selected) element.
await expectFilterItemSelected(namedPopoverFilterItem(page, name));
await page.keyboard.press(KEYBOARD_KEYS.ESCAPE);
await expectFilterPopoverClosed(page);
return name;
Expand Down
Loading