Skip to content

DT-3099: Add configuration, validator, and sample tests for email deny patterns#2919

Draft
rushtong wants to merge 1 commit into
developfrom
gr-DT-3099-add-util-for-email-deny-patterns
Draft

DT-3099: Add configuration, validator, and sample tests for email deny patterns#2919
rushtong wants to merge 1 commit into
developfrom
gr-DT-3099-add-util-for-email-deny-patterns

Conversation

@rushtong

@rushtong rushtong commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Addresses

Partially addresses https://broadworkbench.atlassian.net/browse/DT-3099

Summary

See https://github.com/broadinstitute/terra-helmfile/pull/6446 where we add configuration for global deny patterns.

This PR is restricted in that it provides a basic utility function that could be used for enforcement in other areas of the code. See linked ticket for those areas, but a potential list might be:

  • TDRService.getApprovedUsersForDataset
  • DacResource.addDacMember / addDacChair
  • UserResource.addRoleToUser
  • UserResource.createResearcher

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@sonarqubecloud

sonarqubecloud Bot commented Jun 3, 2026

Copy link
Copy Markdown

@otchet-broad otchet-broad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants