Merge bitcoin/bitcoin#26480: test: Remove wallet option from non-wallet tests

[DashCoreAutoGuix]

Backports bitcoin#26480

Original commit: 8597260

This backport adds the add_wallet_options method to wallet tests and adds -disablewallet flag when descriptors is None, improving test framework wallet option handling.

Changes Summary:

• Added add_wallet_options method to wallet tests
• Added -disablewallet flag in test_node.py when descriptors is None
• Modified test_framework.py to support private wallet options
• Updated various test files to use proper wallet options

Files not modified (don't exist in Dash):

• SegWit/Taproot related test files (14 files)

Scope:

• Bitcoin: 279 lines across 81 files
• Dash: 239 lines across 67 files
• Ratio: 86% (within acceptable range)

[coderabbitai]

Warning

Rate limit exceeded

@DashCoreAutoGuix has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e3d61f2 and f74b0f1.

📒 Files selected for processing (67)

• test/functional/example_test.py (1 hunks)
• test/functional/feature_backwards_compatibility.py (1 hunks)
• test/functional/feature_bip68_sequence.py (1 hunks)
• test/functional/feature_config_args.py (1 hunks)
• test/functional/feature_filelock.py (1 hunks)
• test/functional/feature_init.py (1 hunks)
• test/functional/feature_notifications.py (1 hunks)
• test/functional/feature_pruning.py (1 hunks)
• test/functional/interface_bitcoin_cli.py (2 hunks)
• test/functional/interface_usdt_coinselection.py (1 hunks)
• test/functional/mempool_compatibility.py (1 hunks)
• test/functional/mempool_packages.py (1 hunks)
• test/functional/mempool_persist.py (1 hunks)
• test/functional/mempool_unbroadcast.py (2 hunks)
• test/functional/rpc_createmultisig.py (2 hunks)
• test/functional/rpc_fundrawtransaction.py (1 hunks)
• test/functional/rpc_help.py (1 hunks)
• test/functional/rpc_invalid_address_message.py (1 hunks)
• test/functional/rpc_psbt.py (1 hunks)
• test/functional/rpc_rawtransaction.py (2 hunks)
• test/functional/test_framework/test_framework.py (6 hunks)
• test/functional/test_framework/test_node.py (1 hunks)
• test/functional/tool_wallet.py (1 hunks)
• test/functional/wallet_abandonconflict.py (1 hunks)
• test/functional/wallet_avoidreuse.py (1 hunks)
• test/functional/wallet_backup.py (1 hunks)
• test/functional/wallet_balance.py (1 hunks)
• test/functional/wallet_basic.py (1 hunks)
• test/functional/wallet_coinbase_category.py (1 hunks)
• test/functional/wallet_create_tx.py (1 hunks)
• test/functional/wallet_createwallet.py (1 hunks)
• test/functional/wallet_crosschain.py (1 hunks)
• test/functional/wallet_descriptor.py (1 hunks)
• test/functional/wallet_dump.py (1 hunks)
• test/functional/wallet_encryption.py (1 hunks)
• test/functional/wallet_fallbackfee.py (1 hunks)
• test/functional/wallet_groups.py (1 hunks)
• test/functional/wallet_hd.py (1 hunks)
• test/functional/wallet_import_rescan.py (1 hunks)
• test/functional/wallet_import_with_label.py (1 hunks)
• test/functional/wallet_importdescriptors.py (1 hunks)
• test/functional/wallet_importmulti.py (1 hunks)
• test/functional/wallet_importprunedfunds.py (1 hunks)
• test/functional/wallet_keypool.py (1 hunks)
• test/functional/wallet_keypool_topup.py (1 hunks)
• test/functional/wallet_labels.py (1 hunks)
• test/functional/wallet_listdescriptors.py (1 hunks)
• test/functional/wallet_listreceivedby.py (1 hunks)
• test/functional/wallet_listsinceblock.py (1 hunks)
• test/functional/wallet_listtransactions.py (1 hunks)
• test/functional/wallet_multisig_descriptor_psbt.py (1 hunks)
• test/functional/wallet_multiwallet.py (1 hunks)
• test/functional/wallet_orphanedreward.py (1 hunks)
• test/functional/wallet_reorgsrestore.py (1 hunks)
• test/functional/wallet_resendwallettransactions.py (1 hunks)
• test/functional/wallet_send.py (1 hunks)
• test/functional/wallet_signer.py (1 hunks)
• test/functional/wallet_signmessagewithaddress.py (1 hunks)
• test/functional/wallet_signrawtransactionwithwallet.py (1 hunks)
• test/functional/wallet_simulaterawtx.py (1 hunks)
• test/functional/wallet_startup.py (1 hunks)
• test/functional/wallet_timelock.py (1 hunks)
• test/functional/wallet_transactiontime_rescan.py (1 hunks)
• test/functional/wallet_txn_clone.py (1 hunks)
• test/functional/wallet_txn_doublespend.py (1 hunks)
• test/functional/wallet_upgradewallet.py (1 hunks)
• test/functional/wallet_watchonly.py (1 hunks)

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch backport-0.25-batch-488-pr-26480

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}