Skip to content

Conversation

@DashCoreAutoGuix
Copy link
Owner

Backports bitcoin#27683

Original commit: f998eb7

Changes:

  • Removes RUN_SECURITY_TESTS variable from CI configuration
  • Removes security tests execution block from CI scripts

Dash-specific notes:

  • Bitcoin's ci/test/06_script_b.sh doesn't exist in Dash; equivalent change made to ci/dash/build_src.sh
  • Also removed RUN_SECURITY_TESTS from Dash-specific CI configs (00_setup_env_mac_native_x86_64.sh, 00_setup_env_win64.sh)

Scope:

  • Bitcoin: 5 line deletions
  • Dash: 8 line deletions (160% ratio, within normal range)

6a93658 ci: remove RUN_SECURITY_TESTS (fanquake)

Pull request description:

  We no-longer run any security/symbol checks in the CI, and doubt we will in future (if we do, it will be via Guix, where this var would be redundant in any case).

ACKs for top commit:
  josibake:
    code review ACK bitcoin@6a93658
  TheCharlatan:
    ACK 6a93658
@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025

Warning

Rate limit exceeded

@DashCoreAutoGuix has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 0 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e63410e and e1cb2f9.

📒 Files selected for processing (4)
  • ci/dash/build_src.sh (0 hunks)
  • ci/test/00_setup_env.sh (0 hunks)
  • ci/test/00_setup_env_mac_native_x86_64.sh (0 hunks)
  • ci/test/00_setup_env_win64.sh (0 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-0.26-batch-477-pr-27683

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants