Skip to content

Conversation

@Tinoxy
Copy link

@Tinoxy Tinoxy commented Jan 12, 2026

Add Optimoth

@Tinoxy Tinoxy marked this pull request as draft January 12, 2026 00:11
@Tinoxy Tinoxy marked this pull request as ready for review January 12, 2026 00:11
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Tinoxy, your pull request is larger than the review limit of 150000 diff characters

@do-gamer
Copy link
Contributor

do-gamer commented Jan 12, 2026

@Tinoxy Probably better to add it step by step instead of altogether:

  1. create a branch
  2. add some module or behavior
  3. make pull request
  4. wait for review and merge
  5. go to step 1

About translations better to add prefix berti. (your folder name) to each one your translation key.

Also instead of duplicate many times .activated=Activated you can use general.enabled=Enable

And last one, the plugin.json and strings_en.properties need to update directly in the src/main/resources/

@dm94
Copy link
Contributor

dm94 commented Jan 12, 2026

@Tinoxy Probably better to add it step by step instead of altogether:

  1. create a branch
  2. add some module or behavior
  3. make pull request
  4. wait for review and merge
  5. go to step 1

About translations better to add prefix berti. (your folder name) to each one your translation key.

Also instead of duplicate many times .activated=Activated you can use general.enabled=Enable

And last one, the plugin.json and strings_en.properties need to update directly in the src/main/resources/

Exactly, apart from the fact that if you do it that way, I can't supervise each feature separately and I need to review them separately in case any of them don't comply with the rules.
My recommendation is that you first separate the features that interest you most.

Copy link
Contributor

@dm94 dm94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already mentioned, a PR per functionality.
I would add that these features are those of another plugin that is still available. I don't see the point in adding the same features while the other plugin works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants