-
Notifications
You must be signed in to change notification settings - Fork 6
Add files via upload #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @Tinoxy, your pull request is larger than the review limit of 150000 diff characters
|
@Tinoxy Probably better to add it step by step instead of altogether:
About translations better to add prefix Also instead of duplicate many times And last one, the |
Exactly, apart from the fact that if you do it that way, I can't supervise each feature separately and I need to review them separately in case any of them don't comply with the rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As already mentioned, a PR per functionality.
I would add that these features are those of another plugin that is still available. I don't see the point in adding the same features while the other plugin works.
Add Optimoth