Skip to content

Conversation

@FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Jan 25, 2026

About The Pull Request

mobs are now cleared from the manifest upon matrixing

Why It's Good For The Game

fixes #594
its not fullproof as it only checks name but i dont have many other options.

Changelog

🆑
fix: mobs are now cleared from the manifest upon matrixing
fix: matrixing clears a breacher from the masq
/:cl:

@FalloutFalcon FalloutFalcon requested a review from a team as a code owner January 25, 2026 11:17
@github-actions github-actions bot added the Fix label Jan 25, 2026
Comment on lines 53 to 57
for(var/datum/record/crew/possible_target_record as anything in GLOB.manifest.general)
// Hardly fullproof but dont have a better method to verify as it stores no refs
if(possible_target_record.name == despawning_mob.real_name)
qdel(possible_target_record)
break
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use /datum/record/locked for this. We shouldn't be running into a problem if the manifest is changed via police/medical records in round.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locked is not uses by the manifest but thats what we are trying to fix.

@github-actions github-actions bot requested a review from XeonMations January 27, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Matrixing does not clear manifest

2 participants