Do commands and subtle + subtler #563

XeonMations · 2026-01-23T19:05:29Z

About The Pull Request

Ports:

Peddling Purple Prose: Porting the 'Do' action from F13 NovaSector/NovaSector#725
sloppy port of subtler sound, and its prefs NovaSector/NovaSector#4937
[Port] Subtle improvements, pun intended NovaSector/NovaSector#5818
Subtler defaults to one tile range when provided with a message via emote NovaSector/NovaSector#5871
[PORT] Subtle/r chat filter & Subtle notification sounds NovaSector/NovaSector#6448

Why It's Good For The Game

More small RP features.

Changelog

🆑 XeonMations, yooriss, RatFromTheJungle, OrbisAnimal, FlufflesTheDog, sunnyaries
add: Added Do emotes
add: Added subtle and subtler emotes
/:cl:

FalloutFalcon · 2026-01-23T19:16:47Z

Allows for a lot of believable soft-DMing

From the porting pr.. I've never seen this before, would def like wider feedback from others.
I feel a little warry of it as while we are certainly can lean more MUD then alot of ss13 servers we do at-least in apoc distinctly have admins that actually serve as DMs in the same way most ss13 game masters tend to already do. (I see admins local-narrating ALOT here) I wonder if this steps on the toes on the "authority" we give players vs admins to dictate the canon of a situation if you understand what I mean?

XeonMations · 2026-01-23T19:21:50Z

Allows for a lot of believable soft-DMing

From the porting pr.. I've never seen this before, would def like wider feedback from others. I feel a little warry of it as while we are certainly can lean more MUD then alot of ss13 servers we do at-least in apoc distinctly have admins that actually serve as DMs in the same way most ss13 game masters tend to already do. (I see admins local-narrating ALOT here) I wonder if this steps on the toes on the "authority" we give players vs admins to dictate the canon of a situation if you understand what I mean?

It's essentially the same thing as /me emotes, just formatted differently IMO.

FalloutFalcon

nit: Modular edit comments should really be using the actual module ID

Small note, even on old code, it felt weird having 3 seperate methods of interfacing (for emotes specificly) in a private scene. Subtle is a req as it was in the old code but i worry tossing another verb into the mix. It feels like all of them could do with more unifying of behavior to make everything feel more cohesive.

also try and make sure subtle activates the typing indicator.

FalloutFalcon · 2026-01-23T20:45:02Z

modular_darkpack/modules/do_emotes/readme.md

+
+## \<DO EMOTES>
+
+Module ID: DO EMOTES


i dont think these should have spaces.

Suggested change

Module ID: DO EMOTES

Module ID: DO_EMOTES

FalloutFalcon · 2026-01-23T20:47:05Z

modular_darkpack/modules/subtle/code/subtle.dm

+/datum/config_entry/flag/play_subtler_sound
+	default = TRUE


why is this a config? This is entirely a player pref thing Idk why a server host would ever adjust this.

FalloutFalcon · 2026-01-23T20:49:19Z

modular_darkpack/modules/subtle/code/subtle.dm

+/datum/preference/toggle/subtler_sound
+	savefile_key = "subtler_sound"
+	savefile_identifier = PREFERENCE_PLAYER
+	category = PREFERENCE_CATEGORY_GAME_PREFERENCES
+	default_value = TRUE


Not really within the scope of this pr but this should just be replaced with all our chat messages making sounds (as they do in tfn and apoc)

FalloutFalcon · 2026-01-23T20:51:31Z

modular_darkpack/modules/subtle/code/subtle.dm

+/datum/emote/living/subtle
+	key = "subtle"
+	key_third_person = "subtle"
+	message = null
+	mob_type_blacklist_typecache = list(/mob/living/brain)


Im a bit confused of the value we get out of this being an emote when we override almost all the emote code, and every player that im aware of only interfaces with it via the verb. /datum/emote/living/custom seems to be how me emotes work tho so I guess its valid.

FalloutFalcon · 2026-01-23T20:57:31Z

modular_darkpack/modules/do_emotes/code/do_verbs.dm

+/mob/verb/do_verb(message as message)
+	set name = "Do"
+	set category = "IC"
+	set instant = TRUE
+
+	if(GLOB.say_disabled)
+		to_chat(src, span_danger("Speech is currently admin-disabled."))
+		return
+
+	if(message)
+		QUEUE_OR_CALL_VERB_FOR(VERB_CALLBACK(src, TYPE_VERB_REF(/mob/living, do_actual_verb), message), SSspeech_controller)


do is pretty detached from alot of me code and will definitly function a bit diffrnet because of it.,
me emotes have is_banned_from(user.ckey, "Emote")) and user.client.prefs.muted & MUTE_IC and this also seems to bypass word filters.

FalloutFalcon · 2026-01-23T21:16:17Z

modular_darkpack/modules/subtle/code/subtle.dm

+	for(var/mob/ghost as anything in GLOB.dead_mob_list)
+		if((ghost.client?.prefs.chat_toggles & CHAT_GHOSTSIGHT) && !(ghost in viewers))
+			to_chat(ghost, "[FOLLOW_LINK(ghost, user)] [subtle_message]")


go look at /datum/emote/proc/run_emote
in there it makes sure to filter for isnewplayer which seems to be missing here.

FalloutFalcon · 2026-01-23T21:18:18Z

modular_darkpack/modules/subtle/code/subtle.dm

+
+	subtle_message = span_subtle("<b>[user]</b>[space]<i>[user.apply_message_emphasis(subtle_message)]</i>")
+
+	var/list/viewers = get_hearers_in_view(SUBTLE_ONE_TILE, user)


consider this so that emoting in cars work? I cant think of any negative effects...

Suggested change

var/list/viewers = get_hearers_in_view(SUBTLE_ONE_TILE, user)

var/list/viewers = get_hearers_in_view(SUBTLE_ONE_TILE, get_turf(user))

FalloutFalcon · 2026-01-23T21:18:39Z

modular_darkpack/modules/subtle/code/subtle.dm

+		if(!subtler_emote)
+			return FALSE
+
+		var/list/in_view = get_hearers_in_view(subtler_range, user)


ditto

Suggested change

var/list/in_view = get_hearers_in_view(subtler_range, user)

var/list/in_view = get_hearers_in_view(subtler_range, get_turf(user)))

FalloutFalcon · 2026-01-23T21:28:31Z

modular_darkpack/modules/subtle/code/subtle.dm

+			var/datum/preferences/prefs = target_mob.client?.prefs
+			if(prefs && prefs.read_preference(/datum/preference/toggle/subtler_sound))


ditto for all instances? unless this feels too messy?

Suggested change

var/datum/preferences/prefs = target_mob.client?.prefs

if(prefs && prefs.read_preference(/datum/preference/toggle/subtler_sound))

if(target_mob.client?.prefs?.read_preference(/datum/preference/toggle/subtler_sound))

FalloutFalcon · 2026-01-23T21:32:45Z

tgui/packages/tgui-panel/chat/constants.ts

+  { // DARKPACK EDIT ADDITION START
+    type: MESSAGE_TYPE_SUBTLE,
+    name: 'Subtle',
+    description: 'Subtle and Subtler actions.',
+    selector: '.subtle, .subtler',
+  }, // DARKPACK EDIT ADDITION END


With the fact that basic mobs no longer spam the shit out of ghost ears. These feel like they could be lumped in with emotes without issue. Just a thought.

Latentish · 2026-01-23T21:47:18Z

If I'm honest, I don't see us using this on Apocrypha. It has implications of players using these to describe their environs instead of themselves. Me's mostly cover the RP based usecases for this, as it doesn't force your text into quotation marks but still denotes the post as being from or belonging to a specific character. If anything, I'd just like to make sure this verb is mutable on downstreams if it's included on Dark Pack.

FalloutFalcon · 2026-01-25T12:02:21Z

I saw someone complaining subtler is only 1k characters? forget where.

Do commands

9371405

github-actions bot added UI Feature labels Jan 23, 2026

XeonMations added 2 commits January 23, 2026 21:07

awawa

2cbaec3

Update readme.md

7b50f29

XeonMations changed the title ~~Do commands~~ Do commands and subtle + subtler Jan 23, 2026

XeonMations added 7 commits January 23, 2026 21:48

subtlker

e1c47b4

categories

9e82add

aww

ea3c541

aaaaa

ac1ac67

aaa

f63a400

awawa

f0b23fe

Update subtle.dm

520a2e8

XeonMations marked this pull request as ready for review January 23, 2026 20:20

XeonMations requested a review from a team as a code owner January 23, 2026 20:20

XeonMations added 2 commits January 23, 2026 22:21

awea

3b76161

Update do_verbs.dm

3a437e5

FalloutFalcon requested changes Jan 23, 2026

View reviewed changes


		subtle_message = span_subtle("<b>[user]</b>[space]<i>[user.apply_message_emphasis(subtle_message)]</i>")

		var/list/viewers = get_hearers_in_view(SUBTLE_ONE_TILE, user)

	var/list/in_view = get_hearers_in_view(subtler_range, user)
	var/list/in_view = get_hearers_in_view(subtler_range, get_turf(user)))

		var/datum/preferences/prefs = target_mob.client?.prefs
		if(prefs && prefs.read_preference(/datum/preference/toggle/subtler_sound))

	var/datum/preferences/prefs = target_mob.client?.prefs
	if(prefs && prefs.read_preference(/datum/preference/toggle/subtler_sound))
	if(target_mob.client?.prefs?.read_preference(/datum/preference/toggle/subtler_sound))

Do commands and subtle + subtler #563

Are you sure you want to change the base?

Do commands and subtle + subtler #563

Uh oh!

Conversation

XeonMations commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About The Pull Request

Why It's Good For The Game

Changelog

Uh oh!

FalloutFalcon commented Jan 23, 2026

Uh oh!

XeonMations commented Jan 23, 2026

Uh oh!

FalloutFalcon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Latentish commented Jan 23, 2026

Uh oh!

FalloutFalcon commented Jan 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

XeonMations commented Jan 23, 2026 •

edited

Loading

FalloutFalcon left a comment •

edited

Loading