Align repository with DPC conventions by Copilot · Pull Request #31 · Dans-Plugins/Nether-Access-Controller

Copilot · 2026-03-22T17:43:58Z

Adds all missing documentation and CI/CD files required by the DPC conventions.

README.md

Restructured to match required section order (Description → Installation → Usage → Support → Contributing → Testing → Development → Authors → License → Project Status)
Added links to new in-repo docs (USER_GUIDE.md, COMMANDS.md, CONFIG.md)
Fixed stale links pointing to dmccoystephenson/ → Dans-Plugins/

New documentation files

CONTRIBUTING.md — Fork/branch/PR workflow, build instructions (Maven)
USER_GUIDE.md — First steps, common scenarios, permissions table
COMMANDS.md — All /nac subcommands with syntax, permissions, examples
CONFIG.md — All 5 config options with types, defaults, descriptions
CHANGELOG.md — Keep a Changelog format, entries for v1.0.0 and v1.1.0

CI/CD workflows

.github/workflows/build.yml — Builds on push/PR to main and develop; explicit permissions: contents: read
.github/workflows/release.yml — Builds and attaches target/*.jar on release creation; excludes original-*.jar

Both workflows use Maven (mvn clean package) since the project uses pom.xml, not Gradle.

Copilot instructions

.github/copilot-instructions.md — Technology stack, project structure, coding conventions, contribution workflow

Permission node fix

Updated plugin.yml to declare nac.* permission nodes instead of the incorrect wac.*, aligning with what the Java source (CommandService.java) actually checks at runtime
All documentation (COMMANDS.md, USER_GUIDE.md) uses the correct nac.* permission nodes

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Ref: https://github.com/Dans-Plugins/dpc-conventions Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com> Agent-Logs-Url: https://github.com/Dans-Plugins/Nether-Access-Controller/sessions/d06b5d6f-3f34-4ebd-8c29-4d833bcdb02c

Copilot

Pull request overview

Aligns the repository with Dans Plugins Community (DPC) conventions by adding/standardizing documentation and introducing baseline CI/CD workflows for Maven-based builds and releases.

Changes:

Restructures and updates README.md to match DPC-required section ordering and point to in-repo documentation.
Adds new documentation files: contributing guide, user guide, commands reference, configuration guide, and changelog.
Adds GitHub Actions workflows for PR/push builds and release asset attachment, plus a Copilot instructions file.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`README.md`	Reorders sections per DPC conventions; updates links and adds build/testing guidance.
`USER_GUIDE.md`	Adds end-user setup guidance, common workflows, and a permissions table.
`CONTRIBUTING.md`	Documents contribution workflow and Maven build/manual testing steps.
`COMMANDS.md`	Documents `/nac` subcommands, permissions, usage, and examples.
`CONFIG.md`	Documents config options, defaults, and examples.
`CHANGELOG.md`	Adds Keep a Changelog–style changelog with initial entries.
`.github/workflows/build.yml`	Adds CI build on push/PR to `main`/`develop` using Maven.
`.github/workflows/release.yml`	Builds and uploads `target/*.jar` artifacts to GitHub Releases.
`.github/copilot-instructions.md`	Adds repo/stack/conventions guidance for Copilot contributions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-22T19:05:12Z

USER_GUIDE.md

+| Permission | Default | Description |
+|------------|---------|-------------|
+| `nac.help` | op | Access the help command |
+| `nac.list` | op | View the nether access whitelist |
+| `nac.allow` | op | Allow a player nether access |
+| `nac.deny` | op | Deny a player nether access |
+| `nac.config` | op | View and modify configuration |


The permissions table syntax has an extra leading | on each row (e.g., || Permission | ...), which renders as an unintended empty first column in most Markdown renderers. Use standard table rows starting with a single | for consistent rendering.

Copilot · 2026-03-22T19:05:12Z

USER_GUIDE.md

+| `nac.help` | op | Access the help command |
+| `nac.list` | op | View the nether access whitelist |
+| `nac.allow` | op | Allow a player nether access |
+| `nac.deny` | op | Deny a player nether access |
+| `nac.config` | op | View and modify configuration |


Copilot · 2026-03-22T19:05:12Z

COMMANDS.md

+
+**Description:** Lists all available commands.
+**Permission:** `nac.help`
+**Usage:** `/nac help`


The permissions referenced here are nac.*, but src/main/resources/plugin.yml currently declares wac.* permission nodes. This mismatch can cause confusing default permission behavior; align the documented permission nodes with what the plugin actually defines/enforces.

Copilot · 2026-03-22T19:05:13Z

README.md

+| Name | Main Contributions |
+|------|--------------------|
+| Daniel Stephenson | Creator |


The authors table rows start with ||, which produces an extra empty column in Markdown and may not render as intended. Use a single leading | per row (and adjust the separator row accordingly).

Copilot · 2026-03-22T19:05:13Z

.github/copilot-instructions.md

+
+- `src/main/java/` – Plugin source code
+- `src/main/resources/` – `plugin.yml` and resource files
+- `src/test/java/` – Unit tests


This file states that unit tests live in src/test/java/, but the repository currently only has src/main/ (no src/test/). Please update the project structure section to reflect the current repo layout (or add the test directory if intended).

Suggested change

- `src/test/java/` – Unit tests

- `src/test/java/` – (Optional) Unit tests (create this directory as needed)

Copilot · 2026-03-22T19:05:13Z

.github/workflows/release.yml

+      - name: Upload JAR to release
+        uses: softprops/action-gh-release@v2
+        with:
+          files: target/*.jar


files: target/*.jar will likely upload both the shaded artifact and the original-*.jar produced by maven-shade-plugin, which can confuse releases. Consider uploading only the intended final jar (e.g., exclude original-*.jar or configure shade to not keep the original).

Suggested change

files: target/*.jar

files: |

target/*.jar

!target/original-*.jar

dmccoystephenson · 2026-03-22T19:14:22Z

@copilot address comments

…release glob Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com> Agent-Logs-Url: https://github.com/Dans-Plugins/Nether-Access-Controller/sessions/c71c250a-a4a6-4b4f-bd43-f6bdbac52fa7

Copilot · 2026-03-22T19:15:52Z

@copilot address comments

All review comments addressed in 6a2b151:

Fixed permission nodes from nac.* to wac.* in COMMANDS.md and USER_GUIDE.md to match plugin.yml
Updated src/test/java/ entry in copilot-instructions.md to note the directory should be created as needed
Updated release.yml to exclude original-*.jar from upload glob

dmccoystephenson · 2026-03-22T19:19:20Z

@copilot change all permissions to NAC not wac

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com> Agent-Logs-Url: https://github.com/Dans-Plugins/Nether-Access-Controller/sessions/73794ca4-33bc-4324-8a80-9bd715079832

Copilot · 2026-03-22T19:21:03Z

@copilot change all permissions to NAC not wac

Changed all permission nodes to nac.* in plugin.yml, COMMANDS.md, and USER_GUIDE.md in 70ca6b5. This also fixes the mismatch with the Java source code which already uses nac.* at runtime.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

hub.spigotmc.org
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.13/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.13/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.13 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.13/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/Nether-Access-Controller/Nether-Access-Controller org.codehaus.plexus.classworlds.launcher.Launcher clean package -q (dns block)
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.13/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.13/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.13 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.13/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/Nether-Access-Controller/Nether-Access-Controller org.codehaus.plexus.classworlds.launcher.Launcher clean package (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Initial plan

2a82a2a

Copilot AI assigned Copilot and dmccoystephenson Mar 22, 2026

Copilot started work on behalf of dmccoystephenson March 22, 2026 17:44 View session

Copilot AI changed the title ~~[WIP] Align repository with DPC conventions and documentation~~ Align repository with DPC conventions Mar 22, 2026

Copilot AI requested a review from dmccoystephenson March 22, 2026 17:50

Copilot finished work on behalf of dmccoystephenson March 22, 2026 17:50

dmccoystephenson requested a review from Copilot March 22, 2026 19:01

Copilot started reviewing on behalf of dmccoystephenson March 22, 2026 19:02 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Copilot started work on behalf of dmccoystephenson March 22, 2026 19:14 View session

Copilot finished work on behalf of dmccoystephenson March 22, 2026 19:16

Copilot started work on behalf of dmccoystephenson March 22, 2026 19:19 View session

Change all permissions from wac.* to nac.* in plugin.yml, docs

70ca6b5

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com> Agent-Logs-Url: https://github.com/Dans-Plugins/Nether-Access-Controller/sessions/73794ca4-33bc-4324-8a80-9bd715079832

Copilot finished work on behalf of dmccoystephenson March 22, 2026 19:21

dmccoystephenson marked this pull request as ready for review March 22, 2026 19:24

dmccoystephenson requested a review from Copilot March 22, 2026 19:33

Copilot started reviewing on behalf of dmccoystephenson March 22, 2026 19:34 View session

Copilot AI reviewed Mar 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align repository with DPC conventions#31

Align repository with DPC conventions#31
Copilot wants to merge 4 commits intomasterfrom
copilot/align-repo-with-dpc-conventions

Copilot AI commented Mar 22, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

Copilot AI Mar 22, 2026

Uh oh!

dmccoystephenson commented Mar 22, 2026

Uh oh!

Copilot AI commented Mar 22, 2026

Uh oh!

dmccoystephenson commented Mar 22, 2026

Uh oh!

Copilot AI commented Mar 22, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	- `src/test/java/` – Unit tests
	- `src/test/java/` – (Optional) Unit tests (create this directory as needed)

Conversation

Copilot AI commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

README.md

New documentation files

CI/CD workflows

Copilot instructions

Permission node fix

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

dmccoystephenson commented Mar 22, 2026

Uh oh!

Copilot AI commented Mar 22, 2026

Uh oh!

dmccoystephenson commented Mar 22, 2026

Uh oh!

Copilot AI commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 22, 2026 •

edited

Loading

Copilot AI commented Mar 22, 2026 •

edited

Loading