Convert non-string type to string before calling tracer.recordBinary#36
Open
neo-wanderer wants to merge 18 commits intoDanielMSchmidt:masterfrom
Open
Convert non-string type to string before calling tracer.recordBinary#36neo-wanderer wants to merge 18 commits intoDanielMSchmidt:masterfrom
neo-wanderer wants to merge 18 commits intoDanielMSchmidt:masterfrom
Conversation
Owner
|
Hey @vigneshnrfs Thank you for your help! CI seems to be red, partially on the integration tests, I will try to fix this soon (#37). If it is ok for you I would like to wait until I can do this, if not I will try to verify it and merge it |
Author
|
Hi @DanielMSchmidt Let's fix #37 and then do this merge. This can wait. |
Author
|
This PR also addresses #5 |
Owner
|
Could you rebase this branch? I got at least one of the errors in CI fixed, the other one should also be good now |
Author
|
@DanielMSchmidt It's done. I see just one more failing. |
Owner
|
I will give it a second try, I think it is green on master because there is no change to push for the website |
Author
|
@DanielMSchmidt Can we fix the travis-ci issue and merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.