Add configurable solid background colour behind health bars#300
Open
chrisliebaer wants to merge 1 commit intoDaleHuntGB:masterfrom
Open
Add configurable solid background colour behind health bars#300chrisliebaer wants to merge 1 commit intoDaleHuntGB:masterfrom
chrisliebaer wants to merge 1 commit intoDaleHuntGB:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a solid colour layer behind the health and missing health bars. It's useful when running both bars at low opacity, you get a dark backdrop that makes the bars readable without needing to crank up the bar opacity itself. I use this with class colours at 15% foreground to create a "damage bar" look where the missing health portion pops out. Without the solid background, the low opacity bars look washed out against the game world:
With a black solid background at 70% opacity, the bars sit on a dark base and are properly tinted, muted, but also provide separation from the background.
Default is fully transparent so nothing changes for existing users.
I tried to keep this as close to the existing code style as possible, same colour picker + opacity slider pattern, same default structure, same update path. But if you'd rather handle this differently, I'm happy to rework it. I'd rather iterate on it than have it sit.