Make the loader runs on 16k page size kernel (SCons only) #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tstrap with a different page size
Build arm sel_ldr and nacl_helper_bootstrap with 64K page size alignment. Makes it compatible with 16k page size kernels. SCons plumbing.
illwieckz
changed the title
illwieckz
force-pushed
the
illwieckz/16k-scons
branch
from
e4f3171 to
de2b9ca
Compare
Member
Author
|
Attached is an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from:
I don't know how to test this with SCons, I managed to build Linux amd64 binaries (so I know it doesnt break something that worked), but building the Linux armhf binaries breaks for me, even on
master. I'm not planning to fix scons.This PR makes it possible for @slipher to review and test it without the cmake stuff if he prefers.
It sets the page size to 64k, which is compatible with 64k, 16k, and 4k kernels. I've noticed that Debian Trixie libraries are already aligned on 64k, only the kernel is 16k, so it looks to be a good practice to do so.