chore(lint): fix clang-tidy warnings and doc updates#166
Open
Typas wants to merge 10 commits into
Open
Conversation
…htable C-style casts in OTableIterator silently stripped const from the underlying vector iterator, masking a const-correctness bug. Replaced with reinterpret_cast and derived the `reference` type from VecIterType's value constness so no qualifiers are stripped in either operator* overload. Also adds non-const SubParsers::get_subparsers() overload exposed by the fix: the old cast was allowing mutation through a const map iterator undetected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r APIs cppcoreguidelines-pro-bounds-pointer-arithmetic flagged raw pointer expressions. Replace &*rng.begin() with std::ranges::data(rng), str.data() + str.size() with std::to_address(str.end()), and str.data() + pos with std::next(str.data(), pos). Assembly-verified identical codegen at -O3. Co-Authored-By: Claude <noreply@anthropic.com>
cppcoreguidelines-pro-bounds-pointer-arithmetic fired on all fmt formatter parse() methods that used *it++ and on two util sites. Split *it++ into dereference + std::next(it) in formatter parse() bodies (phase.hpp, pauli_rotation.hpp, stabilizer_tableau.hpp, tableau.hpp). Replaced word.begin()+pos with word.substr(0,pos) in trie.cpp, and raw[0] with *raw in boolean_matrix.cpp. All changes are zero-cost at -O3 (verified via codegen inspection). Co-Authored-By: Claude <noreply@anthropic.com>
std::filesystem::path passed directly to spdlog triggers FMT_STRING consteval format validation which fails because path's formatter is not constexpr-evaluable. Call .string() explicitly at each call site. Co-Authored-By: Claude <noreply@anthropic.com>
clang-tidy readability-inconsistent-ifelse-braces flagged bare single-statement else/else-if branches mixed with braced siblings. Added braces for consistency throughout. Co-Authored-By: Claude <noreply@anthropic.com>
clang-tidy performance-inefficient-vector-operation flagged repeated emplace_back calls in loops without prior reservation. Adding reserve() avoids incremental reallocations. Co-Authored-By: Claude <noreply@anthropic.com>
clang-tidy performance-move-const-arg flagged std::move() calls whose result was passed to push_back(const SubTableau&), making the move a no-op. Adding a push_back(SubTableau&&) overload enables actual moves at the call sites in adaptive_gadget.cpp. Co-Authored-By: Claude <noreply@anthropic.com>
clang-tidy performance-unnecessary-value-param flagged parameters that are copied on every call but only used as const. Changing to const reference avoids the copy with no semantic change. Co-Authored-By: Claude <noreply@anthropic.com>
- Add Fedora dependency installation instructions - Add openSUSE dependency guideline link - Add the OpenBLAS reference for the other distros - Align markdown tables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List
make test?make test-docker?make lintbefore submission?Added
Changed
README.md: expand Linux dependency installation from Ubuntu only to Ubuntu + Fedora. openSUSE has its own wiki page so I add the link. Other Linux distros have a reference link as well.Fixed
src/util/ordered_hashtable.hpp(main),src/argparse/arg_parser.{cpp,hpp}src/util/dvlab_string.hpp,src/tableau/{pauli_rotation,stabilizer_tableau,tableau}.hpp,src/util/{boolean_matrix.cpp,phase.hpp,trie.cpp}. Checked with the compiled asm, no codegen diff.src/qsyn/qsyn_helper.cppwas affected so the fix was applied as well.src/argparse/arg_parser.cpp,src/cmd/{conversion_cmd,qcir_cmd}.cpp,src/device/device.cpp,src/duostra/mapping_eqv_checker.cpp,src/qcir/qcir_reader.cpp,src/util/data_structure_manager_common_cmd.hpp,src/zx/flow/gflow.cppsrc/duostra/placer.cpp,src/tensor/tensor.hppsrc/tableau/tableau.hppsrc/qcir/oracle/pebble.cpp,src/zx/simplifier/simplify.hppRemoved