Skip to content

Comments

Skip the periodic reset during the hit cycle#314

Merged
cuddandr merged 2 commits intodevelopfrom
fix_periodic_reset
Feb 17, 2026
Merged

Skip the periodic reset during the hit cycle#314
cuddandr merged 2 commits intodevelopfrom
fix_periodic_reset

Conversation

@jaafar-chakrani
Copy link
Member

No description provided.

@cuddandr cuddandr self-assigned this Feb 17, 2026
@cuddandr
Copy link
Collaborator

Checked with known charge deposits with and without the fix (ADC noise and diffusion turned off). The fix recovers all the pixels that were missing a hit achieving 100% pixel efficiency and the tail toward lower dataword/charge/energy is less pronounced. With the fix the periodic reset can still cause charge loss, but now is less of an impact.

PRC before fix:
- Total packets: (390463,)
- Unique pixels: (390463,)
PRC after fix:
- Total packets: (409600,)
- Unique pixels: (409600,)
charge_injection_prc_compare

The same plot for a simple muon particle gun before and after the fix (using FSD Sim v4 nominal thresholds) and numbers for pixels/packets. Fewer packets/pixels are lost and fairly uniform across the distributions.

PRC before fix:
- Total packets: (269264,)
- Unique pixels: (160488,)
PRC after fix:
- Total packets: (291473,)
- Unique pixels: (167719,)
fsd_gun_nomThr_compare

@cuddandr cuddandr merged commit 7889d88 into develop Feb 17, 2026
@jaafar-chakrani jaafar-chakrani deleted the fix_periodic_reset branch February 17, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants