NDLAr Config Choices for MiniProdN5 Nominal (Sample A)#302
Merged
alexbooth92 merged 2 commits intodevelopfrom Nov 24, 2025
Merged
NDLAr Config Choices for MiniProdN5 Nominal (Sample A)#302alexbooth92 merged 2 commits intodevelopfrom
alexbooth92 merged 2 commits intodevelopfrom
Conversation
cuddandr
approved these changes
Nov 21, 2025
Collaborator
cuddandr
left a comment
cuddandr
left a comment
There was a problem hiding this comment.
Looks good to me. How concerned are you about running out of GPU memory with the light backtracking and increased max radius? I'm nearly done with halving the light LUT memory size (famous last words) which would cut ~9.5 GB from the simulation.
Member
Author
|
Thanks Andrew! Matt was able to run a successful test with a single file. I guess we'll get a handle on the failure rate due to memory as we scale up 😅 An extra 10 GB of headroom would be very nice! |
mjkramer
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the
max_radiusto 4 and switching on light backtracking for NDLAr.