Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
This PR implements the periodic reset feature in LArPix. In detector operations, LArPix typically operates with a periodic reset to drain away slowly-accumulating charge on the front end due to e.g. leakage currents. In the past, this reset has been set to a period of ~400 microseconds, which means that it wasn't particularly important to simulate (as a drift window is ~200 microseconds). However, to mitigate far field effects, a significantly faster periodic reset has been used in more recent LArPix operations, with O(10 microsecond) periods, making it more important to take into account.
Implementation
icreaches the periodic reset in fee.get_adc_values,true_qandq_sumare set to 0 and to the reset noise respectively, and the backtrackingcurrent_fractionsis updated accordingly.qsandtrue_qsarrays to record the changes to the charge at each time tick and save arrays of interest in an.npzfile for debugging purposes. To be removed once this is validated.Validation
So far, I ran a couple events with 25.6 and 10000.0 microseconds to compare the changes to the waveforms.
Further validation is still needed:
Remaining code updates
periodic_reset_cycles < 0)