Add DAPHNE ETH peak descriptor support#49
Open
marroyav wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No parent issue linked yet.
This PR adds DAPHNE Ethernet peak descriptor support to
DAPHNEEthFramefor theFDDAQ
v5.5.0target environment.The change adds typed access to the DAPHNE Ethernet peak descriptor words,
exposes the new descriptor accessors through Python bindings, and adds a
DAPHNEEthFrame_testunit test covering ADC, header, peak descriptor, andpacked-word roundtrip behavior.
Target environment:
fddaq-v5.5.0-a9-1fddaq-v5.5.0/v2.6.0np04-srv-017Dependencies:
rawdatautilsbranchmarroyav/daphneeth-fddaq-v5_5_0depends on this dataformat API.For the paired end-to-end decode smoke test, also build the matching
rawdatautilsbranch and run:Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Testing performed on
np04-srv-017:dbt-build -c -j4passed.dbt-build --unittest fddetdataformatspassed.DAPHNEEthFrame_testpassed as part of the package unit tests.rawdatautilspassed on run43950,VD_CathodePDS, record(1, 0):800:1407DAPHNEEthframes801:1395DAPHNEEthframesMinimal system quicktest, full integration tests, separate Python pytest, and
pre-commit were not run.
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))
dbt-build --lintwas not run. New unit coverage was added inunittest/DAPHNEEthFrame_test.cxx.