Skip to content

Apply DUNE-DAQ style guide: modernize type aliases and namespace syntax#42

Open
Copilot wants to merge 4 commits into
developfrom
copilot/review-code-with-styleguide
Open

Apply DUNE-DAQ style guide: modernize type aliases and namespace syntax#42
Copilot wants to merge 4 commits into
developfrom
copilot/review-code-with-styleguide

Conversation

Copy link
Copy Markdown

Copilot AI commented Jan 7, 2026

Description

Comprehensive style guide compliance review identified minor deviations from dune-daq/styleguide standards across header files.

Changes

Type aliases (§7.7): Replaced C-style typedef with modern using declarations in 10 header files:

// Before
typedef uint32_t word_t;

// After
using word_t = uint32_t;

Namespace syntax (§4.1): Updated to C++17 compact form in DAPHNEFrame.hpp:

// Before
namespace dunedaq {
namespace fddetdataformats {

// After
namespace dunedaq::fddetdataformats {

Formatting: Fixed spacing inconsistencies around assignment operators and replaced tabs with spaces.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Header-only style changes. Syntax validation confirms correctness. No functional changes.

Further checks

Original prompt

review code in this repo using dune-daq/styleguide


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 7, 2026 15:47
…nd fix formatting

Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>
Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>
Copilot AI changed the title [WIP] Review code using dune-daq styleguide Apply DUNE-DAQ style guide: modernize type aliases and namespace syntax Jan 7, 2026
Copilot AI requested a review from eflumerf January 7, 2026 15:50
@eflumerf eflumerf requested a review from jcfreeman2 January 14, 2026 20:46
@eflumerf eflumerf marked this pull request as ready for review January 14, 2026 20:46
Copy link
Copy Markdown
Contributor

@jcfreeman2 jcfreeman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; one less thing to mention for the fddetdataformats code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants