Apply DUNE-DAQ style guide: modernize type aliases and namespace syntax#42
Open
Copilot wants to merge 4 commits into
Open
Apply DUNE-DAQ style guide: modernize type aliases and namespace syntax#42Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
…nd fix formatting Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>
Co-authored-by: eflumerf <61473357+eflumerf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review code using dune-daq styleguide
Apply DUNE-DAQ style guide: modernize type aliases and namespace syntax
Jan 7, 2026
eflumerf
approved these changes
Jan 14, 2026
jcfreeman2
approved these changes
Mar 18, 2026
Contributor
jcfreeman2
left a comment
There was a problem hiding this comment.
LGTM; one less thing to mention for the fddetdataformats code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Comprehensive style guide compliance review identified minor deviations from dune-daq/styleguide standards across header files.
Changes
Type aliases (§7.7): Replaced C-style
typedefwith modernusingdeclarations in 10 header files:Namespace syntax (§4.1): Updated to C++17 compact form in DAPHNEFrame.hpp:
Formatting: Fixed spacing inconsistencies around assignment operators and replaced tabs with spaces.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Header-only style changes. Syntax validation confirms correctness. No functional changes.
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.