Handle team clarification edge cases #3187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevinjil
approved these changes
Nov 9, 2025
| ->getQuery() | ||
| ->getResult(); | ||
| ->addOrderBy('c.clarid', 'DESC'); | ||
| if (!$this->dj->checkrole('jury') && $contest->getStartTimeObject()->getTimestamp() > time()) { |
Member
There was a problem hiding this comment.
Are we sure we want this first part? Even if you are jury, do we want to show these clarifications on the team pages? I think this might confuse people.
Member
Author
There was a problem hiding this comment.
I was thinking the same thing, and the thing I think I wanted the most is to as a jury member be able to "restrict" the view to what a team would see or get all the information.
I'll make it uniform for now.
vmcj
force-pushed
the
jury_clarification_warning_extraction_team_clar_submit
branch
from
5616ca0 to
978bf7b
Compare
nickygerritsen
approved these changes
Nov 23, 2025
We already disclose those in the API, so keep this consistent. This does result in the `contest time` of that clarification to be negative but thats factually true.
vmcj
force-pushed
the
jury_clarification_warning_extraction_team_clar_submit
branch
from
978bf7b to
e9bfad0
Compare
vmcj
deleted the
jury_clarification_warning_extraction_team_clar_submit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of commits from: #3174 which are expected to already get approved to make discussion easier.