Remove macos13, runners are deprecated at github#239
Remove macos13, runners are deprecated at github#239jwillemsen merged 1 commit intoDOCGroup:masterfrom
Conversation
* .github/workflows/macosx.yml:
WalkthroughThe macOS CI workflow has been narrowed to remove macOS 13 from the build matrix, retaining only macOS 14. This reduces the number of concurrent CI builds without modifying any workflow logic or steps. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/macosx.yml (1)
19-26: LGTM! Removal of deprecated macos-13 runner is correct.The macOS 13 runner image was retired by December 4th, 2025, and the images are now fully unsupported. GitHub Actions started the deprecation process for macOS 13 and macOS 13 arm64.
Migrating to
macos-14is a valid approach. As an optional enhancement, you might consider expanding the matrix to includemacos-15(ormacos-latest) to ensure broader compatibility testing, since workflows that are architecture agnostic are encouraged to transition to arm64 labels such as macos-15, macos-latest, or macos-14.💡 Optional: Expand matrix to include macos-15
strategy: matrix: cxxstd: ["17"] - os: [macos-14] + os: [macos-14, macos-15] include: - platform_file: include $(ACE_ROOT)/include/makeinclude/platform_macosx.GNU
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/macosx.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: macos-14-C++17
- GitHub Check: VS2022Debug64
- GitHub Check: windows-2022 vs2022
- GitHub Check: ubuntu-24.04 g++-10
- GitHub Check: VS2022Release32
- GitHub Check: Codacy Static Code Analysis
Summary by CodeRabbit
No changes visible to end-users.
✏️ Tip: You can customize this high-level summary in your review settings.