Skip to content

Minimal backport of https://github.com/DOCGroup/ACE_TAO/pull/2513#2516

Merged
jwillemsen merged 1 commit intoDOCGroup:ace6tao2from
jwillemsen:jwi-configtestacetao2
Mar 12, 2026
Merged

Minimal backport of https://github.com/DOCGroup/ACE_TAO/pull/2513#2516
jwillemsen merged 1 commit intoDOCGroup:ace6tao2from
jwillemsen:jwi-configtestacetao2

Conversation

@jwillemsen
Copy link
Copy Markdown
Member

@jwillemsen jwillemsen commented Mar 12, 2026

* ACE/tests/Config_Test.cpp:

Summary by CodeRabbit

  • Tests
    • Updated test configuration to reflect current user registry context instead of machine-wide registry settings.

    * ACE/tests/Config_Test.cpp:
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 47e7a013-8e00-4ad2-ac27-5d7bfd752677

📥 Commits

Reviewing files that changed from the base of the PR and between 08ab15f and 67aa653.

📒 Files selected for processing (1)
  • ACE/tests/Config_Test.cpp

Walkthrough

Registry configuration in test suite updated from machine-wide (HKEY_LOCAL_MACHINE) to user-specific (HKEY_CURRENT_USER) context. Registry paths renamed from Software\ACE\test to Software\ACETEST\test. Error messages and resolve_key operations updated consistently throughout test file.

Changes

Cohort / File(s) Summary
Registry Context Switch
ACE/tests/Config_Test.cpp
Updated test registry hive from HKEY_LOCAL_MACHINE to HKEY_CURRENT_USER; renamed registry paths from Software\ACE\test to Software\ACETEST\test; updated error message text and all resolve_key/remove_key/open operations to reference new paths consistently.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 With whiskers twitching, I hop with glee,
User registry paths, for you and me!
No machine-wide halls, just CURRENT_USER's keep,
ACETEST softly nested, secrets safe and deep.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references a specific upstream PR (2513) and clearly indicates this is a backport, which aligns with the actual changes being a minimal registry configuration update in Config_Test.cpp.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jwillemsen
Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 12, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jwillemsen jwillemsen merged commit 98e5a3f into DOCGroup:ace6tao2 Mar 12, 2026
26 of 27 checks passed
@jwillemsen jwillemsen deleted the jwi-configtestacetao2 branch March 12, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant