Skip to content

Use HKEY_CURRENT_USER for testing (backport #2513)#2515

Closed
mergify[bot] wants to merge 3 commits intoace6tao2from
mergify/bp/ace6tao2/pr-2513
Closed

Use HKEY_CURRENT_USER for testing (backport #2513)#2515
mergify[bot] wants to merge 3 commits intoace6tao2from
mergify/bp/ace6tao2/pr-2513

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Mar 11, 2026

Use HKEY_CURRENT_USER for testing as HKEY_LOCAL_MACHINE can't be changed when this test runs under a normal user. Also use const/addressof in various places

Summary by CodeRabbit

  • Refactor
    • Updated code initialization patterns and formatting standards in configuration modules for improved consistency and maintainability. These are internal improvements with no impact on user-facing functionality.

This is an automatic backport of pull request #2513 done by [Mergify](https://mergify.com).

Use HKEY_CURRENT_USER for testing as HKEY_LOCAL_MACHINE can't be changed when this test runs under a normal user. Also use const/addressof in various places

(cherry picked from commit 5f51784)

# Conflicts:
#	ACE/ace/Configuration.cpp
(cherry picked from commit 15e17eb)
@mergify
Copy link
Copy Markdown
Author

mergify bot commented Mar 11, 2026

Cherry-pick of 5f51784 has failed:

On branch mergify/bp/ace6tao2/pr-2513
Your branch is up to date with 'origin/ace6tao2'.

You are currently cherry-picking commit 5f51784b33.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ACE/tests/Config_Test.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ACE/ace/Configuration.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@jwillemsen jwillemsen closed this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant