OVH: fix ovh integration tests for release_candidate_v5#4453
Draft
masterzen wants to merge 1 commit into
Draft
Conversation
This fixes parsing native TXT records for the OVH provider.
Contributor
Author
|
While this fixes some of the integration tests, some are still failing: I need to have a deeper look. |
59 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This makes the integration tests pass for the OVH provider on top of the release_candidate_v5 work.
Why?
TXT record parsing seems to have changed, and TXT records where quoted again when parsed.