Skip to content

[CU-86bar2y9c] Support platform admins (no namespace) for global workflow creates#179

Merged
ch-dna merged 1 commit into
mainfrom
fix-blank-namespace-global-CU-86bar2y9c
Jul 3, 2026
Merged

[CU-86bar2y9c] Support platform admins (no namespace) for global workflow creates#179
ch-dna merged 1 commit into
mainfrom
fix-blank-namespace-global-CU-86bar2y9c

Conversation

@ch-dna

@ch-dna ch-dna commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

• get_workflow_client now takes global_action; when set with no namespace it uses a
"global" placeholder path segment and skips the users/me lookup that fails for
namespace-less platform admins (workflow-service ignores the path ns for global ops)
• Forward global_action from the 5 POST-create commands: workflow, version, defaults,
transformation, dependency
• Make WorkbenchUser.default_namespace Optional so accountless-namespace users no longer
crash pydantic on a null default_namespace
• Add unit tests for the getter global/explicit/default branches and the model change
• Scope note: delete/update (etag pre-fetch GET), PUT updates, and read/list global are
intentionally NOT included — they require back-end changes (see design doc + follow-up ticket)

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

…flow creates

• get_workflow_client now takes global_action; when set with no namespace it uses a
  "global" placeholder path segment and skips the users/me lookup that fails for
  namespace-less platform admins (workflow-service ignores the path ns for global ops)
• Forward global_action from the 5 POST-create commands: workflow, version, defaults,
  transformation, dependency
• Make WorkbenchUser.default_namespace Optional so accountless-namespace users no longer
  crash pydantic on a null default_namespace
• Add unit tests for the getter global/explicit/default branches and the model change
• Scope note: delete/update (etag pre-fetch GET), PUT updates, and read/list global are
  intentionally NOT included — they require back-end changes (see design doc + follow-up ticket)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
11124 6673 60% 30% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
dnastack/cli/commands/workbench/workflows/commands.py 41% 🟢
dnastack/cli/commands/workbench/workflows/utils.py 45% 🟢
dnastack/cli/commands/workbench/workflows/versions/commands.py 48% 🟢
dnastack/cli/commands/workbench/workflows/versions/defaults.py 60% 🟢
dnastack/cli/commands/workbench/workflows/versions/dependencies/commands.py 76% 🟢
dnastack/cli/commands/workbench/workflows/versions/transformations.py 49% 🟢
dnastack/client/workbench/workbench_user_service/models.py 100% 🟢
dnastack/client/workbench/workflow/client.py 62% 🟢
TOTAL 60% 🟢

updated for commit: 542d6f8 by action🐍

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.98%. Comparing base (8186ed1) to head (542d6f8).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...stack/cli/commands/workbench/workflows/commands.py 0.00% 1 Missing ⚠️
.../commands/workbench/workflows/versions/defaults.py 0.00% 1 Missing ⚠️
...ds/workbench/workflows/versions/transformations.py 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   59.59%   59.98%   +0.39%     
==========================================
  Files         180      181       +1     
  Lines       11056    11124      +68     
==========================================
+ Hits         6589     6673      +84     
+ Misses       4467     4451      -16     
Flag Coverage Δ
unittests 59.98% <72.72%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@platform-automation-dnastack

Copy link
Copy Markdown

@ch-dna ch-dna merged commit 520331d into main Jul 3, 2026
6 checks passed
@ch-dna ch-dna deleted the fix-blank-namespace-global-CU-86bar2y9c branch July 3, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants