Skip to content

[ros_introspection] Fix NoneType error in remove_element #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IamPhytan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ros_introspection] Fix NoneType error in remove_element #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions ros_introspection/src/ros_introspection/package_xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,12 +324,13 @@ def add_packages(self, build_depends, run_depends, test_depends=None, prefer_dep
def remove_element(self, element):
"""Remove the given element AND the text element before it if it is just an indentation."""
parent = element.parentNode
index = parent.childNodes.index(element)
if index > 0:
previous = parent.childNodes[index - 1]
if previous.nodeType == previous.TEXT_NODE and INDENT_PATTERN.match(previous.nodeValue):
parent.removeChild(previous)
parent.removeChild(element)
if parent is not None:
index = parent.childNodes.index(element)
if index > 0:
previous = parent.childNodes[index - 1]
if previous.nodeType == previous.TEXT_NODE and INDENT_PATTERN.match(previous.nodeValue):
parent.removeChild(previous)
parent.removeChild(element)
self.changed = True

def remove_dependencies(self, name, pkgs, quiet=False):
Expand Down