Skip to content

chore: remove fastapi status and add ruff rule#923

Merged
aldbr merged 4 commits into
DIRACGrid:mainfrom
Stellatsuu:remove-fastapi-status
Jun 3, 2026
Merged

chore: remove fastapi status and add ruff rule#923
aldbr merged 4 commits into
DIRACGrid:mainfrom
Stellatsuu:remove-fastapi-status

Conversation

@Stellatsuu
Copy link
Copy Markdown
Contributor

Closes: #823

Question:
Ruff is currently ran on diracx related code only:

[tool.ruff]
src = ["diracx-*/src", "diracx-*/tests"]

For this issue, I had to change some parts of code related to gubbins, should we also add it to ruff or not?

@Stellatsuu Stellatsuu requested review from aldbr and chrisburr June 1, 2026 13:12
@Stellatsuu Stellatsuu self-assigned this Jun 1, 2026
@Stellatsuu Stellatsuu marked this pull request as draft June 1, 2026 13:13
@aldbr aldbr linked an issue Jun 1, 2026 that may be closed by this pull request
@aldbr
Copy link
Copy Markdown
Contributor

aldbr commented Jun 1, 2026

Thanks @Stellatsuu, is that ready to be reviewed? If so please mark it a ready for review 🙂

@Stellatsuu Stellatsuu marked this pull request as ready for review June 2, 2026 07:35
@Stellatsuu
Copy link
Copy Markdown
Contributor Author

It is ready @aldbr, I was waiting for the CI to pass before removing the draft. Could you please respond to my question in the PR description before merging anything? In case I need to do some changes related to that

Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
@DIRACGridBot DIRACGridBot marked this pull request as draft June 2, 2026 08:41
@aldbr
Copy link
Copy Markdown
Contributor

aldbr commented Jun 2, 2026

For this issue, I had to change some parts of code related to gubbins, should we also add it to ruff or not?

Yes please also apply your changes to gubbins and add the ruff rules to the pyproject.toml there

@Stellatsuu Stellatsuu marked this pull request as ready for review June 2, 2026 09:34
@aldbr aldbr force-pushed the remove-fastapi-status branch from 93bfc37 to 4d29913 Compare June 3, 2026 12:30
@aldbr aldbr merged commit 06b9cee into DIRACGrid:main Jun 3, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[refactor] Use fastapi.status instead of http.HTTPStatus in DiracX API

2 participants