chore: remove fastapi status and add ruff rule#923
Merged
Conversation
Contributor
|
Thanks @Stellatsuu, is that ready to be reviewed? If so please mark it a ready for review 🙂 |
Contributor
Author
|
It is ready @aldbr, I was waiting for the CI to pass before removing the draft. Could you please respond to my question in the PR description before merging anything? In case I need to do some changes related to that |
aldbr
requested changes
Jun 2, 2026
Contributor
Yes please also apply your changes to gubbins and add the ruff rules to the |
93bfc37 to
4d29913
Compare
aldbr
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #823
Question:
Ruff is currently ran on
diracxrelated code only:For this issue, I had to change some parts of code related to
gubbins, should we also add it to ruff or not?