[int] Check all random module usage#8562
Draft
sfayer wants to merge 1 commit into
Draft
Conversation
sfayer
requested review from
andresailer,
atsareg,
chaen and
fstagni
as code owners
fstagni
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a start of clearing up for bandit tests (part of #8547): I've been through all the usages of the random to ensure it isn't used for security purposes. In all cases but one I've just added a hint comment. For the proxy serial numbers, I did a bit more investigation, random is fine there (but seeing as I was changing it I swapped it our for secret). I decided it needs a bit more number space to avoid the possibility of a collision (not that anyone would probably notice but we want to stay compliant with the RFC if possible).
Regards,
Simon
BEGINRELEASENOTES
*All
CHANGE: Check all random module usage
CHANGE: Increase proxy serial length
ENDRELEASENOTES