Read Vehicle Definition MMY from definitions by ID#164
Open
JamesReate wants to merge 5 commits intomainfrom
Open
Read Vehicle Definition MMY from definitions by ID#164JamesReate wants to merge 5 commits intomainfrom
JamesReate wants to merge 5 commits intomainfrom
Conversation
Member
|
I would consider telling GQLGen that |
Member
Author
I'll read up on GQLGen see how that works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
WHERE INclause followed by the list of definition id's, with a max of 1000 (don't believe we'd allow paging bigger than 1k).Background:
The definition ID is what drives what definition the vehicle is set to. Most clients will use the Make, Model, Year in the vehicle response from identity-api to show users their MMY. In the past, we had thought having the MMY on the vehicle nft made sense, but lately seems to add complexity/issues.
The objective of this PR is to solve for the user experience issues we've seen reported over time where the definition ID doesn't match the MMY.