Closed
Conversation
Member
|
The generate linter is failing. This should pass. |
elffjs
approved these changes
Feb 23, 2026
Member
There was a problem hiding this comment.
Okay, I think I've got the code generation checker set. protobuf is annoying because it's not a Go binary.
I have no idea how the method in the Swagger got out of sync. It's specified once in code and once in a comment so it's surprising that it doesn't happen more often.
I am worried that someone—maybe even one of our services—is going to rely on the old behavior and that it's going to hurt us. Let's find out.
Member
|
Okay I just checked nginx logs and no one is calling this. Very free. |
Member
Author
|
Don't think we need this pr anymore now that we're on graphQL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Swagger discrepancies
Summary
the router registration which was returning 405 Not Allowed previously
type, source, producer, before, after, limit) across all four handlers
tokenIdpath parameter type fromstringtointegerin all handler annotationsparams in a logical order
@SecurityBearerAuth annotation to all four endpoints, which was missing and caused the endpoints to appearas unauthenticated in the Swagger UI
expected format