Remove VIN vs vehicle definition match check#112
Merged
Conversation
- Drop decode-VIN and compare-to-NameSlug validation in vinvc.getValidFingerPrint - Remove VINAPI dependency from vinvc service and device-definitions gRPC from app setup - Remove vinvalidator usage and deviceDefAPIClientFromSettings - Update vinvc tests and regenerate mocks Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the check that required the VIN (from telemetry) to decode to the same device definition as the vehicle's registered definition.
Changes
DecodeVINanddecodedNameSlug == vehicleInfo.NameSlugvalidation ingetValidFingerPrintdeviceDefAPIClientFromSettingsVIN attestation now uses the latest fingerprint VIN from paired devices without validating it against the vehicle's definition ID.
Made with Cursor