Skip to content

Test mikeio1d linux installation #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpalm3r wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Test mikeio1d linux installation #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce049e5
pinning mikeio1d
jpalm3r Jun 2, 2026
2f69737
Fixing wrong pin
jpalm3r Jun 2, 2026
82eb727
Include (again) test network in full test workflow
jpalm3r Jun 2, 2026
5f1ee84
Include (again) build with no networks
jpalm3r Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions .github/workflows/full_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@
enable-cache: true

- name: Install dependencies
# (Reactivate once it works with mikeio1d)
#run: uv sync --group test --group networks --no-dev
run: uv sync --group test --no-dev
run: uv sync --group test --group networks --no-dev

- name: Install pandas 2.x
if: matrix.pandas-version == 'pandas2'
Expand All @@ -56,23 +54,22 @@
- name: Test
run: just test

# TODO: activate once above runs with -- group networks
# build-no-networks:
# runs-on: ubuntu-latest
build-no-networks:
runs-on: ubuntu-latest

# steps:
# - uses: actions/checkout@v4
steps:
- uses: actions/checkout@v4

# - uses: extractions/setup-just@v3
- uses: extractions/setup-just@v3

# - name: Set up uv
# uses: astral-sh/setup-uv@v6
# with:
# python-version: "3.11"
# enable-cache: true
- name: Set up uv
uses: astral-sh/setup-uv@v6
with:
python-version: "3.11"
enable-cache: true

# - name: Install dependencies (without networks)
# run: uv sync --group test --no-dev
- name: Install dependencies (without networks)
run: uv sync --group test --no-dev

# - name: Test
# run: just test
- name: Test
run: just test

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Comment on lines +58 to +75
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ test = [

notebooks = ["nbformat", "nbconvert", "jupyter", "plotly", "shapely", "seaborn"]

networks = ["mikeio1d", "networkx"]
networks = ["mikeio1d==1.2.1", "networkx"]

[project.urls]
"Homepage" = "https://github.com/DHI/modelskill"
Expand Down
Loading