Remove mikeio rename(inplace=...) warning path from DFSU point matching

[Copilot]

ms.match() with DfsuModelResult could emit repeated mikeio FutureWarning messages about deprecated inplace rename behavior, creating noisy notebook output despite successful matching. This change removes that warning path while preserving model-item naming in extracted point results.

• DFSU point extraction

  • Updated DfsuModelResult._extract_point to avoid mikeio.Dataset.rename(...) on the extracted dataset.
  • Renames the first extracted value item by updating the dataset’s internal name mapping in place (no full Dataset/DataArray copy rebuild).
  • Keeps aux items intact and unchanged.

• Regression coverage

  • Added a focused test in tests/test_match.py that treats the specific mikeio deprecation warning as an error and verifies ms.match([o1, o2], mr1) succeeds without triggering it.

# before
ds_model = ds_model.rename({ds_model.items[0].name: self.name})

# after
old_name = ds_model.items[0].name
if old_name != self.name:
    da = ds_model._data_vars.pop(old_name)
    da.name = self.name
    ds_model._data_vars[self.name] = da
    ds_model._del_name_attr(old_name)
    ds_model._set_name_attr(self.name, da)

[ryan-kipawa]

Identify where the inplace call is being made before you make a fix. You must understand the problem before fixing it, even with TDD. One should also avoid unnecessary copies where possible, both for performance reasons as well as replication / internal consistency. Try again

[Copilot]

Identify where the inplace call is being made before you make a fix. You must understand the problem before fixing it, even with TDD. One should also avoid unnecessary copies where possible, both for ...

Addressed in 8d9eaff.

I traced the warning source to _extract_point calling ds_model.rename(...), which triggers mikeio’s deprecated inplace rename path on affected versions. I replaced that call with an in-place key/name update on the extracted dataset’s first DataArray (no full Dataset/DataArray copies), while preserving aux items and dataset consistency.

[ryan-kipawa]

I still think it's wrong. The code you removed did not have an inplace parameter, it was indeed how the warning advised resolving the issue.

[Copilot]

I still think it's wrong. The code you removed did not have an inplace parameter, it was indeed how the warning advised resolving the issue.

Updated in 2e6f873: I reverted _extract_point to use ds_model = ds_model.rename({ds_model.items[0].name: self.name}) and removed the direct private _data_vars mutation path.