Fix: Auto-register wallet for existing users#219
Draft
TaprootFreak wants to merge 3 commits intodevelopfrom
Draft
Fix: Auto-register wallet for existing users#219TaprootFreak wants to merge 3 commits intodevelopfrom
TaprootFreak wants to merge 3 commits intodevelopfrom
Conversation
When a user already has account data but the current wallet is not registered, automatically register the wallet in the background instead of showing the "Registrierung erforderlich" error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When a user has multiple wallets or creates a new wallet, they may encounter the "Registrierung erforderlich" (Registration required) error on the Buy page, even though they already have completed registration with another wallet.
Root cause: Registration in the DFX system works on two levels:
When a user with existing account data tries to buy with a new/unregistered wallet, the API returns
REGISTRATION_REQUIRED. Previously, the app would show an error message and require the user to manually go through the KYC/registration flow again - even though all their data is already in the system.Solution
When the
REGISTRATION_REQUIREDerror is returned:getWalletStatus()userDataexists → automatically callregisterWallet()to register the current walletThis provides a seamless experience for existing users adding new wallets.
Changes
BuyPaymentInfoCubit: Added_tryAutoRegisterWallet()method that attempts automatic wallet registrationBuyPage: Added required service dependenciesTest plan